Skip to content

Logical operators - #181

Merged
pasor1 merged 24 commits into
javascript-tutorial:masterfrom
Dorin-David:article/11-logical-operators
Jan 24, 2021
Merged

Logical operators#181
pasor1 merged 24 commits into
javascript-tutorial:masterfrom
Dorin-David:article/11-logical-operators

Conversation

@Dorin-David

@Dorin-DavidDorin-David commented Jan 22, 2021

Copy link
Copy Markdown
Contributor

Ho finito la revisione dell'articolo sui logical operators. C'erano un pochino di cosette da sistemare. Per favore controllare e fatemi sapere so mi sono perso qualcosa.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJanuary 22, 2021 13:28
@pasor1pasor1 changed the title Article/11 logical operatorsLogical operatorsJan 22, 2021
@pasor1pasor1 mentioned this pull request Jan 22, 2021
Open
@pasor1pasor1 self-assigned this Jan 22, 2021
@Dorin-David

Dorin-David commented Jan 23, 2021

Copy link
Copy Markdown
ContributorAuthor

@pasor1 Chiariscimi un dubbio cortesemente. Sto revisionando l'articolo sui loop, dove negli snippet con codici i commenti sono scritti in italiano; in questo articolo, pero', li ho lasciati in inglese. Come ci comportiamo a riguardo? Dovremmo farlo presente anche agli altri, non penso sia chiara la cosa...

@longo-andrealongo-andrea mentioned this pull request Jan 23, 2021
Closed
48 tasks
pasor1
pasor1 reviewed Jan 23, 2021
View reviewed changes

@pasor1pasor1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pasor1 Chiariscimi un dubbio cortesemente. Sto revisionando l'articolo sui loop, dove negli snippet con codici i commenti sono scritti in italiano; in questo articolo, pero', li ho lasciati in inglese. Come ci comportiamo a riguardo? Dovremmo farlo presente anche agli altri, non penso sia chiara la cosa...

Come regola, negli esempi di codice traduciamo solo i commenti, non traduciamo il codice (variabili, funzioni, ecc...)

Comment thread1-js/02-first-steps/11-logical-operators/6-check-if-in-range/task.md Outdated
Scrivi una condizione `if` per controllare che `age` sia compresa tra `14` e `90` estremi inclusi.

"Inclusi" significa che `age` può valere anche `14` o `90`.
Scrivi una condizione `if` per controllare che `age` sia compresa tra `14` e `90` (inclusi: `age` può valere anche `14` o `90`).

@pasor1pasor1Jan 22, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mi sembrava un po' più chiaro prima della correzione...

pasor1
pasor1 requested changes Jan 23, 2021
View reviewed changes
Comment thread1-js/02-first-steps/11-logical-operators/2-alert-or/solution.md Outdated
Comment thread1-js/02-first-steps/11-logical-operators/article.md Outdated
Comment thread1-js/02-first-steps/11-logical-operators/article.md Outdated
Comment thread1-js/02-first-steps/11-logical-operators/article.md Outdated
Comment thread1-js/02-first-steps/11-logical-operators/article.md Outdated
Comment thread1-js/02-first-steps/11-logical-operators/article.md Outdated
Comment thread1-js/02-first-steps/11-logical-operators/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jan 23, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@Dorin-David@pasor1
Update 1-js/02-first-steps/11-logical-operators/2-alert-or/solution.md
27587d1
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
Dorin-Davidand others added 8 commits January 23, 2021 23:32
@Dorin-David@pasor1
Update 1-js/02-first-steps/11-logical-operators/article.md
f92c0cb
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@Dorin-David@pasor1
Update 1-js/02-first-steps/11-logical-operators/article.md
1a39e5f
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@Dorin-David@pasor1
Update 1-js/02-first-steps/11-logical-operators/article.md
803368d
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@Dorin-David@pasor1
Update 1-js/02-first-steps/11-logical-operators/article.md
9930428
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@Dorin-David@pasor1
Update 1-js/02-first-steps/11-logical-operators/article.md
e2c97bd
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@Dorin-David@pasor1
Update 1-js/02-first-steps/11-logical-operators/article.md
b54fa5a
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@Dorin-David
Update task.md
f25f2a6
@Dorin-David
Update solution.md
c6a51aa
@Dorin-David

Dorin-David commented Jan 24, 2021

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJanuary 24, 2021 07:09
pasor1
pasor1 approved these changes Jan 24, 2021
View reviewed changes

@pasor1pasor1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pasor1
pasor1 merged commit f17f17e into javascript-tutorial:masterJan 24, 2021
@javascript-translate-bot

javascript-translate-bot commented Jan 24, 2021

Copy link
Copy Markdown

Error: the article already translated in the Progress Issue #1⁉️

@Dorin-David
Dorin-David deleted the article/11-logical-operators branch January 27, 2021 09:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@longo-andrealongo-andrealongo-andrea left review comments
@pasor1pasor1pasor1 approved these changes

Assignees

@pasor1pasor1

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Dorin-David@javascript-translate-bot@longo-andrea@pasor1