Skip to content

Property flags and descriptors - #196

Merged
longo-andrea merged 6 commits into
javascript-tutorial:masterfrom
longo-andrea:article/property-descriptors
Feb 1, 2021
Merged

Property flags and descriptors#196
longo-andrea merged 6 commits into
javascript-tutorial:masterfrom
longo-andrea:article/property-descriptors

Conversation

@longo-andrea

@longo-andrealongo-andrea commented Jan 27, 2021

Copy link
Copy Markdown
Contributor

In questo articolo non è stato facile decidere cosa tenere in inglese e cosa tradurre in italiano

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJanuary 27, 2021 21:02
@javascript-translate-botjavascript-translate-bot mentioned this pull request Jan 27, 2021
Open
Dorin-David
Dorin-David reviewed Jan 27, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 27, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 27, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
@longo-andrea@Dorin-David
Apply suggestions from code review
ce13c67
Co-authored-by: Dorin-David <70648503+Dorin-David@users.noreply.github.com>
@longo-andrea

longo-andrea commented Jan 27, 2021

Copy link
Copy Markdown
ContributorAuthor

/done

Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Dorin-David
Dorin-David reviewed Jan 28, 2021
View reviewed changes

@Dorin-DavidDorin-David left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ci sono alcune piccole modifiche e suggerimenti. Ottima traduzione, comunque!

longo-andreaand others added 3 commits January 29, 2021 20:50
@longo-andrea@Dorin-David
Apply suggestions from code review
7578a6b
Co-authored-by: Dorin-David <70648503+Dorin-David@users.noreply.github.com>
@longo-andrea@Dorin-David
Update 1-js/07-object-properties/01-property-descriptors/article.md
9d70d12
Co-authored-by: Dorin-David <70648503+Dorin-David@users.noreply.github.com>
@longo-andrea@Dorin-David
Update 1-js/07-object-properties/01-property-descriptors/article.md
900083d
Co-authored-by: Dorin-David <70648503+Dorin-David@users.noreply.github.com>
@longo-andrea

longo-andrea commented Jan 29, 2021

Copy link
Copy Markdown
ContributorAuthor

/done

pasor1
pasor1 approved these changes Jan 31, 2021
View reviewed changes

@pasor1pasor1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un paio di note

Comment thread1-js/07-object-properties/01-property-descriptors/article.md
@@ -120,21 +120,21 @@ user.name = "Pete"; // Error: Cannot assign to read only property 'name'
*/!*

@pasor1pasor1Jan 31, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ci sarebbe il commento nel codice da tradurre, linea 119

@longo-andrealongo-andreaJan 31, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qui non ho tradotto perché suppongo (ma non sono sicuro) che sia il messaggio di errore che ti appare.. e ho paura che traducendolo perda di senso, visto che poi non apparirà mai in italiano... però non ci metterei la mano sul fuoco, smentitemi se sto dicendo una cavolata

Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
@longo-andrea@pasor1
Apply suggestions from code review
5edd17b
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea
longo-andrea merged commit a86fbfc into javascript-tutorial:masterFeb 1, 2021
@javascript-translate-bot

javascript-translate-bot commented Feb 1, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@longo-andrea
longo-andrea deleted the article/property-descriptors branch February 7, 2021 13:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pasor1pasor1pasor1 approved these changes
+1 more reviewer
@Dorin-DavidDorin-DavidDorin-David left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@longo-andrea@javascript-translate-bot@pasor1@Dorin-David