Skip to content

Property getters and setters - #199

Merged
pasor1 merged 3 commits into
javascript-tutorial:masterfrom
longo-andrea:article/getters-setters
Feb 6, 2021
Merged

Property getters and setters#199
pasor1 merged 3 commits into
javascript-tutorial:masterfrom
longo-andrea:article/getters-setters

Conversation

@longo-andrea

@longo-andrealongo-andrea commented Jan 30, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJanuary 30, 2021 18:33
@javascript-translate-botjavascript-translate-bot mentioned this pull request Jan 30, 2021
Open
@pasor1pasor1 self-assigned this Jan 31, 2021
pasor1
pasor1 requested changes Jan 31, 2021
View reviewed changes

@pasor1pasor1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qualche suggerimento

Comment thread1-js/07-object-properties/02-property-accessors/article.md Outdated
Comment thread1-js/07-object-properties/02-property-accessors/article.md Outdated
Comment thread1-js/07-object-properties/02-property-accessors/article.md Outdated
Comment thread1-js/07-object-properties/02-property-accessors/article.md Outdated
Comment thread1-js/07-object-properties/02-property-accessors/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jan 31, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

longo-andreaand others added 2 commits January 31, 2021 21:26
@longo-andrea@pasor1
Apply suggestions from code review
8abdb4b
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea@pasor1
Update 1-js/07-object-properties/02-property-accessors/article.md
7f714de
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea

longo-andrea commented Jan 31, 2021

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJanuary 31, 2021 20:26
@pasor1
pasor1 merged commit 67a15a5 into javascript-tutorial:masterFeb 6, 2021
@javascript-translate-bot

javascript-translate-bot commented Feb 6, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@longo-andrea
longo-andrea deleted the article/getters-setters branch February 7, 2021 13:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pasor1pasor1pasor1 approved these changes

Assignees

@pasor1pasor1

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@longo-andrea@javascript-translate-bot@pasor1