Skip to content

Event delegation - #203

Merged
longo-andrea merged 14 commits into
javascript-tutorial:masterfrom
pierangelomiceli:evtdeleg
Feb 9, 2021
Merged

Event delegation#203
longo-andrea merged 14 commits into
javascript-tutorial:masterfrom
pierangelomiceli:evtdeleg

Conversation

@pierangelomiceli

@pierangelomicelipierangelomiceli commented Feb 6, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamFebruary 6, 2021 00:16
@javascript-translate-botjavascript-translate-bot mentioned this pull request Feb 6, 2021
Open
@longo-andrea

longo-andrea commented Feb 6, 2021

Copy link
Copy Markdown
Contributor

@pierangelomiceli intanto correggo l'articolo, manca però la traduzione degli esercizi e delle soluzioni

longo-andrea
longo-andrea reviewed Feb 6, 2021
View reviewed changes

@longo-andrealongo-andrea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ho fatto solamente un check dei typos, dopo leggo l'articolo e ti do un feedback più dettagliato

Comment thread2-ui/2-events/03-event-delegation/article.md Outdated
@pierangelomiceli@longo-andrea
Update 2-ui/2-events/03-event-delegation/article.md
885c818
Co-authored-by: Andrea <45577511+longo-andrea@users.noreply.github.com>
longo-andrea
longo-andrea requested changes Feb 6, 2021
View reviewed changes
Comment thread2-ui/2-events/03-event-delegation/article.md Outdated
Comment thread2-ui/2-events/03-event-delegation/article.md Outdated
Comment thread2-ui/2-events/03-event-delegation/article.md Outdated
Chiarimenti:
1. Il metodo `elem.closest(selector)` ritorna l'antenato più vicino che combacia con il selettore. Nel nostro caso cerchiamo un `<td>` verso l'alto dall'elemento di origine dell'evento.
2. Se `event.target` non è dentro nessun `<td>`, la chiamata esce immediatamente, dal momento che non c'è nulla da fare.
3. Ne caso di tabelle annidate, `event.target` potrebbe essere un `<td>`, ma fuori dalla tabelle corrente. Quindi andiamo a controllare se sia il `<td>` della *nostra tabella*.

@longo-andrealongo-andreaFeb 6, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3.Ne caso di tabelle annidate, `event.target` potrebbe essere un `<td>`, ma fuori dalla tabelle corrente. Quindi andiamo a controllare se sia il `<td>` della *nostra tabella*.
3.Nel caso di tabelle annidate, `event.target` potrebbe essere un `<td>`, ma fuori dalla tabelle corrente. Quindi andiamo a controllare se sia il `<td>` della *nostra tabella*.

@pierangelomicelipierangelomiceliFeb 6, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/done

Comment thread2-ui/2-events/03-event-delegation/article.md Outdated
Comment thread2-ui/2-events/03-event-delegation/article.md Outdated
Comment thread2-ui/2-events/03-event-delegation/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Feb 6, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

pierangelomiceliand others added 5 commits February 6, 2021 23:07
@pierangelomiceli@longo-andrea
Update 2-ui/2-events/03-event-delegation/article.md
b3998d6
Co-authored-by: Andrea <45577511+longo-andrea@users.noreply.github.com>
@pierangelomiceli@longo-andrea
Update 2-ui/2-events/03-event-delegation/article.md
e16545e
Co-authored-by: Andrea <45577511+longo-andrea@users.noreply.github.com>
@pierangelomiceli@longo-andrea
Update 2-ui/2-events/03-event-delegation/article.md
631f802
Co-authored-by: Andrea <45577511+longo-andrea@users.noreply.github.com>
@pierangelomiceli@longo-andrea
Update 2-ui/2-events/03-event-delegation/article.md
5ef4eb4
Co-authored-by: Andrea <45577511+longo-andrea@users.noreply.github.com>
@pierangelomiceli@longo-andrea
Update 2-ui/2-events/03-event-delegation/article.md
056feff
Co-authored-by: Andrea <45577511+longo-andrea@users.noreply.github.com>
@longo-andrealongo-andrea mentioned this pull request Feb 7, 2021
Merged
@longo-andrea

longo-andrea commented Feb 7, 2021

Copy link
Copy Markdown
Contributor

Gli esercizi tradotti sono nella PR #205

pasor1
pasor1 approved these changes Feb 9, 2021
View reviewed changes

@pasor1pasor1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qualche pioccola nota

Comment thread2-ui/2-events/03-event-delegation/article.md Outdated
Comment thread2-ui/2-events/03-event-delegation/article.md Outdated
Comment thread2-ui/2-events/03-event-delegation/article.md Outdated
Comment thread2-ui/2-events/03-event-delegation/article.md Outdated
Comment thread2-ui/2-events/03-event-delegation/article.md Outdated
Comment thread2-ui/2-events/03-event-delegation/article.md Outdated
Comment thread2-ui/2-events/03-event-delegation/article.md Outdated
pierangelomiceliand others added 7 commits February 9, 2021 20:08
@pierangelomiceli@pasor1
Update 2-ui/2-events/03-event-delegation/article.md
79052f2
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@pierangelomiceli@pasor1
Update 2-ui/2-events/03-event-delegation/article.md
be65476
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@pierangelomiceli@pasor1
Update 2-ui/2-events/03-event-delegation/article.md
86b7b35
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@pierangelomiceli@pasor1
Update 2-ui/2-events/03-event-delegation/article.md
fc8c16b
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@pierangelomiceli@pasor1
Update 2-ui/2-events/03-event-delegation/article.md
4861f1a
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@pierangelomiceli@pasor1
Update 2-ui/2-events/03-event-delegation/article.md
7fa0157
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@pierangelomiceli@pasor1
Update 2-ui/2-events/03-event-delegation/article.md
bdcf7d6
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea
longo-andrea merged commit 8aeeedb into javascript-tutorial:masterFeb 9, 2021
@javascript-translate-bot

javascript-translate-bot commented Feb 9, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@longo-andrealongo-andrealongo-andrea approved these changes
@pasor1pasor1pasor1 approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pierangelomiceli@longo-andrea@javascript-translate-bot@pasor1