Skip to content

Native prototypes - #210

Merged
longo-andrea merged 2 commits into
javascript-tutorial:masterfrom
longo-andrea:article/3-native-prototypes
Feb 22, 2021
Merged

Native prototypes#210
longo-andrea merged 2 commits into
javascript-tutorial:masterfrom
longo-andrea:article/3-native-prototypes

Conversation

@longo-andrea

@longo-andrealongo-andrea commented Feb 9, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamFebruary 9, 2021 21:39
@javascript-translate-botjavascript-translate-bot mentioned this pull request Feb 9, 2021
Open
Dorin-David
Dorin-David reviewed Feb 22, 2021
View reviewed changes
Comment thread1-js/08-prototypes/03-native-prototypes/2-defer-to-prototype-extended/solution.md Outdated
Dorin-David
Dorin-David reviewed Feb 22, 2021
View reviewed changes
Comment thread1-js/08-prototypes/03-native-prototypes/article.md Outdated
Dorin-David
Dorin-David reviewed Feb 22, 2021
View reviewed changes
Comment thread1-js/08-prototypes/03-native-prototypes/article.md Outdated
Dorin-David
Dorin-David reviewed Feb 22, 2021
View reviewed changes
Comment thread1-js/08-prototypes/03-native-prototypes/article.md Outdated
Dorin-David
Dorin-David reviewed Feb 22, 2021
View reviewed changes
Comment thread1-js/08-prototypes/03-native-prototypes/article.md Outdated
Dorin-David
Dorin-David reviewed Feb 22, 2021
View reviewed changes
Comment thread1-js/08-prototypes/03-native-prototypes/article.md Outdated
Dorin-David
Dorin-David reviewed Feb 22, 2021
View reviewed changes
Comment thread1-js/08-prototypes/03-native-prototypes/article.md Outdated
Dorin-David
Dorin-David reviewed Feb 22, 2021
View reviewed changes
Comment thread1-js/08-prototypes/03-native-prototypes/article.md Outdated
Dorin-David
Dorin-David reviewed Feb 22, 2021
View reviewed changes
Comment thread1-js/08-prototypes/03-native-prototypes/article.md Outdated
Dorin-David
Dorin-David reviewed Feb 22, 2021
View reviewed changes
Comment thread1-js/08-prototypes/03-native-prototypes/article.md Outdated
Dorin-David
Dorin-David reviewed Feb 22, 2021
View reviewed changes
Comment thread1-js/08-prototypes/03-native-prototypes/article.md Outdated
Dorin-David
Dorin-David reviewed Feb 22, 2021
View reviewed changes
Comment thread1-js/08-prototypes/03-native-prototypes/article.md Outdated
Dorin-David
Dorin-David reviewed Feb 22, 2021
View reviewed changes
Comment thread1-js/08-prototypes/03-native-prototypes/article.md
Alcuni metodi dei native prototype sono presi in prestito.

For instance, if we're making an array-like object, we may want to copy some `Array` methods to it.
Ad esempio, se stiamo costruendo un oggetto simil-array, potremmo voler copiare alcuni metodi degli `Array`.

@Dorin-DavidDorin-DavidFeb 22, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Ad esempio, se stiamo costruendo un oggetto simil-array, potremmo voler copiare alcuni metodi degli `Array`.
Ad esempio, se stiamo costruendo un oggetto simile a un array, potremmo voler copiare alcuni metodi degli `Array`.

@pasor1pasor1Feb 22, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In molte parti le tutorial viene utilizzato simil-array, secondo me rende meglio l'idea rispetto a "simile ad una array" e dè più visino all' originale array-like

Dorin-David
Dorin-David reviewed Feb 22, 2021
View reviewed changes
Comment thread1-js/08-prototypes/03-native-prototypes/article.md Outdated
Dorin-David
Dorin-David suggested changes Feb 22, 2021
View reviewed changes

@Dorin-DavidDorin-David left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revisione traduzione

@javascript-translate-bot

javascript-translate-bot commented Feb 22, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

pasor1
pasor1 approved these changes Feb 22, 2021
View reviewed changes
Comment thread1-js/08-prototypes/03-native-prototypes/article.md Outdated
Comment thread1-js/08-prototypes/03-native-prototypes/article.md
Alcuni metodi dei native prototype sono presi in prestito.

For instance, if we're making an array-like object, we may want to copy some `Array` methods to it.
Ad esempio, se stiamo costruendo un oggetto simil-array, potremmo voler copiare alcuni metodi degli `Array`.

@pasor1pasor1Feb 22, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In molte parti le tutorial viene utilizzato simil-array, secondo me rende meglio l'idea rispetto a "simile ad una array" e dè più visino all' originale array-like

@longo-andrea@Dorin-David@pasor1
Apply suggestions from code review
3f4d9d1
Co-authored-by: Dorin-David <70648503+Dorin-David@users.noreply.github.com>
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea
longo-andrea merged commit 52b7e58 into javascript-tutorial:masterFeb 22, 2021
@javascript-translate-bot

javascript-translate-bot commented Feb 22, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@longo-andrea
longo-andrea deleted the article/3-native-prototypes branch March 7, 2021 20:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pasor1pasor1pasor1 approved these changes
+1 more reviewer
@Dorin-DavidDorin-DavidDorin-David requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@longo-andrea@javascript-translate-bot@pasor1@Dorin-David