Skip to content

Extending built-in classes - #237

Merged
longo-andrea merged 4 commits into
javascript-tutorial:masterfrom
longo-andrea:article/extend-builtin
Mar 7, 2021
Merged

Extending built-in classes#237
longo-andrea merged 4 commits into
javascript-tutorial:masterfrom
longo-andrea:article/extend-builtin

Conversation

@longo-andrea

@longo-andrealongo-andrea commented Mar 2, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMarch 2, 2021 20:19
@javascript-translate-botjavascript-translate-bot mentioned this pull request Mar 2, 2021
Open
Dorin-David
Dorin-David reviewed Mar 5, 2021
View reviewed changes
Comment thread1-js/09-classes/05-extend-natives/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 5, 2021
View reviewed changes
Comment thread1-js/09-classes/05-extend-natives/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 5, 2021
View reviewed changes
Comment thread1-js/09-classes/05-extend-natives/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 5, 2021
View reviewed changes
Comment thread1-js/09-classes/05-extend-natives/article.md Outdated
Dorin-David
Dorin-David suggested changes Mar 5, 2021
View reviewed changes

@Dorin-DavidDorin-David left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alcune piccole correzioni

@javascript-translate-bot

javascript-translate-bot commented Mar 5, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

longo-andreaand others added 2 commits March 5, 2021 13:48
@longo-andrea@Dorin-David
Apply suggestions from code review
33f81da
Co-authored-by: Dorin-David <70648503+Dorin-David@users.noreply.github.com>
@longo-andrea@Dorin-David
Apply suggestions from code review
a7c55bb
Co-authored-by: Dorin-David <70648503+Dorin-David@users.noreply.github.com>
@longo-andrea

longo-andrea commented Mar 5, 2021

Copy link
Copy Markdown
ContributorAuthor

/done

pasor1
pasor1 approved these changes Mar 7, 2021
View reviewed changes
Comment thread1-js/09-classes/05-extend-natives/article.md Outdated
Comment thread1-js/09-classes/05-extend-natives/article.md Outdated
Comment thread1-js/09-classes/05-extend-natives/article.md Outdated
Comment thread1-js/09-classes/05-extend-natives/article.md Outdated
Comment thread1-js/09-classes/05-extend-natives/article.md Outdated
Comment thread1-js/09-classes/05-extend-natives/article.md Outdated
@longo-andrea@pasor1
Apply suggestions from code review
5fc16b7
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea
longo-andrea merged commit e3810c6 into javascript-tutorial:masterMar 7, 2021
@javascript-translate-bot

javascript-translate-bot commented Mar 7, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@longo-andrea
longo-andrea deleted the article/extend-builtin branch March 7, 2021 20:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pasor1pasor1pasor1 approved these changes
+1 more reviewer
@Dorin-DavidDorin-DavidDorin-David requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@longo-andrea@javascript-translate-bot@pasor1@Dorin-David