Skip to content

Private and protected properties and method - #240

Merged
pasor1 merged 5 commits into
javascript-tutorial:masterfrom
longo-andrea:article/private-protected-methods
Mar 7, 2021
Merged

Private and protected properties and method#240
pasor1 merged 5 commits into
javascript-tutorial:masterfrom
longo-andrea:article/private-protected-methods

Conversation

@longo-andrea

@longo-andrealongo-andrea commented Mar 5, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMarch 5, 2021 21:29
@longo-andrealongo-andrea mentioned this pull request Mar 6, 2021
Open
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Dorin-David
Dorin-David suggested changes Mar 6, 2021
View reviewed changes

@Dorin-DavidDorin-David left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho suggerito alcune modifiche

@javascript-translate-bot

javascript-translate-bot commented Mar 6, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@longo-andrea@Dorin-David
Apply suggestions from code review
e859b82
Co-authored-by: Dorin David <70648503+Dorin-David@users.noreply.github.com>
@longo-andrea

longo-andrea commented Mar 7, 2021

Copy link
Copy Markdown
ContributorAuthor

/done

@longo-andrea

longo-andrea commented Mar 7, 2021

Copy link
Copy Markdown
ContributorAuthor

Ho aggiunto qui la traduzione del titolo del capitolo, mi ero completamente dimenticato 😅

pasor1
pasor1 requested changes Mar 7, 2021
View reviewed changes
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
Comment thread1-js/09-classes/04-private-protected-properties-methods/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Mar 7, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@longo-andrea@pasor1
Apply suggestions from code review
23ca259
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea

longo-andrea commented Mar 7, 2021

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMarch 7, 2021 14:56
@pasor1
pasor1 merged commit 86f5d0a into javascript-tutorial:masterMar 7, 2021
@longo-andrea
longo-andrea deleted the article/private-protected-methods branch March 7, 2021 20:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pasor1pasor1pasor1 approved these changes
+1 more reviewer
@Dorin-DavidDorin-DavidDorin-David requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@longo-andrea@javascript-translate-bot@pasor1@Dorin-David