Skip to content

Dynamic imports - #244

Merged
longo-andrea merged 3 commits into
javascript-tutorial:masterfrom
longo-andrea:article/dynamic-imports
Mar 7, 2021
Merged

Dynamic imports#244
longo-andrea merged 3 commits into
javascript-tutorial:masterfrom
longo-andrea:article/dynamic-imports

Conversation

@longo-andrea

@longo-andrealongo-andrea commented Mar 6, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMarch 6, 2021 14:32
@javascript-translate-botjavascript-translate-bot mentioned this pull request Mar 6, 2021
Open
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/13-modules/03-modules-dynamic-imports/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/13-modules/03-modules-dynamic-imports/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes
Comment thread1-js/13-modules/03-modules-dynamic-imports/article.md Outdated
Dorin-David
Dorin-David reviewed Mar 6, 2021
View reviewed changes

@Dorin-DavidDorin-David left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

piccole modifiche

@longo-andrea@Dorin-David
Apply suggestions from code review
f35a2be
Co-authored-by: Dorin David <70648503+Dorin-David@users.noreply.github.com>
pasor1
pasor1 approved these changes Mar 7, 2021
View reviewed changes
Comment thread1-js/13-modules/03-modules-dynamic-imports/article.md Outdated
Comment thread1-js/13-modules/03-modules-dynamic-imports/article.md Outdated
Comment thread1-js/13-modules/03-modules-dynamic-imports/article.md Outdated
Comment thread1-js/13-modules/03-modules-dynamic-imports/article.md Outdated
Comment thread1-js/13-modules/03-modules-dynamic-imports/article.md Outdated
Comment thread1-js/13-modules/03-modules-dynamic-imports/article.md Outdated
Comment thread1-js/13-modules/03-modules-dynamic-imports/article.md Outdated
@longo-andrea@pasor1
Apply suggestions from code review
01bcd23
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea
longo-andrea merged commit b44a948 into javascript-tutorial:masterMar 7, 2021
@javascript-translate-bot

javascript-translate-bot commented Mar 7, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@longo-andrea
longo-andrea deleted the article/dynamic-imports branch March 7, 2021 20:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pasor1pasor1pasor1 approved these changes
+1 more reviewer
@Dorin-DavidDorin-DavidDorin-David left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2nd review done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@longo-andrea@javascript-translate-bot@pasor1@Dorin-David