Skip to content

Attributes and properties - #267

Merged
longo-andrea merged 6 commits into
javascript-tutorial:masterfrom
Dorin-David:attributes-and-properties
Mar 23, 2021
Merged

Attributes and properties#267
longo-andrea merged 6 commits into
javascript-tutorial:masterfrom
Dorin-David:attributes-and-properties

Conversation

@Dorin-David

@Dorin-DavidDorin-David commented Mar 17, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMarch 17, 2021 21:35
@javascript-translate-botjavascript-translate-bot mentioned this pull request Mar 17, 2021
Open
longo-andrea
longo-andrea requested changes Mar 20, 2021
View reviewed changes

@longo-andrealongo-andrea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ottima traduzione as always 👍 Principalmente sono tutte piccolezze, se hai dubbi su qualche correzione fammi sapere!

Comment thread2-ui/1-document/06-dom-attributes-and-properties/article.md Outdated
Comment thread2-ui/1-document/06-dom-attributes-and-properties/article.md Outdated
Comment thread2-ui/1-document/06-dom-attributes-and-properties/article.md Outdated
Comment thread2-ui/1-document/06-dom-attributes-and-properties/article.md Outdated
Comment thread2-ui/1-document/06-dom-attributes-and-properties/article.md Outdated
Comment thread2-ui/1-document/06-dom-attributes-and-properties/article.md Outdated
Comment thread2-ui/1-document/06-dom-attributes-and-properties/article.md Outdated
Comment thread2-ui/1-document/06-dom-attributes-and-properties/article.md Outdated
Comment thread2-ui/1-document/06-dom-attributes-and-properties/article.md Outdated
Comment thread2-ui/1-document/06-dom-attributes-and-properties/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Mar 20, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Dorin-Davidand others added 4 commits March 20, 2021 19:13
@Dorin-David@longo-andrea
Update 2-ui/1-document/06-dom-attributes-and-properties/article.md
d396f6b
Co-authored-by: Andrea <45577511+longo-andrea@users.noreply.github.com>
@Dorin-David@longo-andrea
Update 2-ui/1-document/06-dom-attributes-and-properties/article.md
1913c0b
Co-authored-by: Andrea <45577511+longo-andrea@users.noreply.github.com>
@Dorin-David@longo-andrea
Update 2-ui/1-document/06-dom-attributes-and-properties/article.md
507f207
Co-authored-by: Andrea <45577511+longo-andrea@users.noreply.github.com>
@Dorin-David@longo-andrea
Apply suggestions from code review
6e30f20
Co-authored-by: Andrea <45577511+longo-andrea@users.noreply.github.com>
@Dorin-David

Dorin-David commented Mar 20, 2021

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMarch 20, 2021 18:23
pasor1
pasor1 requested changes Mar 21, 2021
View reviewed changes
Comment thread2-ui/1-document/06-dom-attributes-and-properties/article.md Outdated
Comment thread2-ui/1-document/06-dom-attributes-and-properties/article.md Outdated
Comment thread2-ui/1-document/06-dom-attributes-and-properties/article.md Outdated
Comment thread2-ui/1-document/06-dom-attributes-and-properties/article.md Outdated
Comment thread2-ui/1-document/06-dom-attributes-and-properties/article.md Outdated
Comment thread2-ui/1-document/06-dom-attributes-and-properties/2-yellow-links/solution.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Mar 21, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@Dorin-David@pasor1
Apply suggestions from code review
897f499
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@Dorin-David

Dorin-David commented Mar 21, 2021

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMarch 21, 2021 12:23
@longo-andrea
longo-andrea merged commit 7b1ea9e into javascript-tutorial:masterMar 23, 2021
@javascript-translate-bot

javascript-translate-bot commented Mar 23, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@longo-andrealongo-andrealongo-andrea approved these changes
@pasor1pasor1pasor1 approved these changes

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Dorin-David@javascript-translate-bot@longo-andrea@pasor1