Skip to content

Popups and window methods - #269

Merged
longo-andrea merged 3 commits into
javascript-tutorial:masterfrom
longo-andrea:article/popup-windows
Mar 28, 2021
Merged

Popups and window methods#269
longo-andrea merged 3 commits into
javascript-tutorial:masterfrom
longo-andrea:article/popup-windows

Conversation

@longo-andrea

@longo-andrealongo-andrea commented Mar 21, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMarch 21, 2021 15:20
@javascript-translate-botjavascript-translate-bot mentioned this pull request Mar 21, 2021
Open
pasor1
pasor1 requested changes Mar 26, 2021
View reviewed changes

@pasor1pasor1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corretto qualche "typo".
In molte situazioni ho suggerito "finestra popup" anziché "finestra di popup",
Idem per "il tab" al posto di "la tab" , ma qui si va un po' ad abitudine personale, anche se in genere i neologismi prendono il maschile.

Comment thread3-frames-and-windows/01-popup-windows/article.md Outdated
Comment thread3-frames-and-windows/01-popup-windows/article.md Outdated
Comment thread3-frames-and-windows/01-popup-windows/article.md Outdated
Comment thread3-frames-and-windows/01-popup-windows/article.md Outdated
Comment thread3-frames-and-windows/01-popup-windows/article.md Outdated
Comment thread3-frames-and-windows/01-popup-windows/article.md Outdated
Comment thread3-frames-and-windows/01-popup-windows/article.md Outdated
Comment thread3-frames-and-windows/01-popup-windows/article.md Outdated
Comment thread3-frames-and-windows/01-popup-windows/article.md Outdated
Comment thread3-frames-and-windows/01-popup-windows/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Mar 26, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@longo-andrea@pasor1
Apply suggestions from code review
0f55b61
Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>
@longo-andrea

longo-andrea commented Mar 26, 2021

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMarch 26, 2021 20:10
@longo-andrea
longo-andrea merged commit a65802b into javascript-tutorial:masterMar 28, 2021
@javascript-translate-bot

javascript-translate-bot commented Mar 28, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@longo-andrea
longo-andrea deleted the article/popup-windows branch April 10, 2021 14:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pasor1pasor1pasor1 requested changes

Assignees

No one assigned

Labels

needs +1review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@longo-andrea@javascript-translate-bot@pasor1