Skip to content

Custom elements - #277

Merged
longo-andrea merged 15 commits into
javascript-tutorial:masterfrom
pierangelomiceli:025_cust_ele
Apr 5, 2021
Merged

Custom elements#277
longo-andrea merged 15 commits into
javascript-tutorial:masterfrom
pierangelomiceli:025_cust_ele

Conversation

@pierangelomiceli

@pierangelomicelipierangelomiceli commented Mar 27, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMarch 27, 2021 17:01
@javascript-translate-botjavascript-translate-bot mentioned this pull request Mar 27, 2021
Open
longo-andrea
longo-andrea requested changes Mar 29, 2021
View reviewed changes
Comment thread8-web-components/2-custom-elements/article.md Outdated
Comment thread8-web-components/2-custom-elements/article.md Outdated
Comment thread8-web-components/2-custom-elements/article.md Outdated
Comment thread8-web-components/2-custom-elements/article.md Outdated
Comment thread8-web-components/2-custom-elements/article.md Outdated
Comment thread8-web-components/2-custom-elements/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Mar 29, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

pierangelomiceliand others added 7 commits March 29, 2021 23:35
@pierangelomiceli@longo-andrea
Update 8-web-components/2-custom-elements/article.md
c17bf77
Co-authored-by: Andrea <45577511+longo-andrea@users.noreply.github.com>
@pierangelomiceli@longo-andrea
Update 8-web-components/2-custom-elements/article.md
8542399
Co-authored-by: Andrea <45577511+longo-andrea@users.noreply.github.com>
@pierangelomiceli@longo-andrea
Update 8-web-components/2-custom-elements/article.md
e70721d
Co-authored-by: Andrea <45577511+longo-andrea@users.noreply.github.com>
@pierangelomiceli@longo-andrea
Update 8-web-components/2-custom-elements/article.md
b9f2a98
Co-authored-by: Andrea <45577511+longo-andrea@users.noreply.github.com>
@pierangelomiceli@longo-andrea
Update 8-web-components/2-custom-elements/article.md
92f372b
Co-authored-by: Andrea <45577511+longo-andrea@users.noreply.github.com>
@pierangelomiceli@longo-andrea
Update 8-web-components/2-custom-elements/article.md
bf0cbf5
Co-authored-by: Andrea <45577511+longo-andrea@users.noreply.github.com>
@pierangelomiceli
Merge branch 'master' into 025_cust_ele
8ee6d05
@pierangelomiceli

pierangelomiceli commented Mar 29, 2021

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMarch 29, 2021 21:38
@pierangelomiceli

pierangelomiceli commented Mar 29, 2021

Copy link
Copy Markdown
ContributorAuthor

/done

Dorin-David
Dorin-David reviewed Apr 3, 2021
View reviewed changes
Comment thread8-web-components/2-custom-elements/article.md Outdated
Dorin-David
Dorin-David reviewed Apr 3, 2021
View reviewed changes
Comment thread8-web-components/2-custom-elements/article.md Outdated
Dorin-David
Dorin-David reviewed Apr 3, 2021
View reviewed changes
Comment thread8-web-components/2-custom-elements/article.md Outdated
Dorin-David
Dorin-David reviewed Apr 3, 2021
View reviewed changes
Comment thread8-web-components/2-custom-elements/article.md Outdated
Dorin-David
Dorin-David reviewed Apr 3, 2021
View reviewed changes
Comment thread8-web-components/2-custom-elements/article.md Outdated
Dorin-David
Dorin-David reviewed Apr 3, 2021
View reviewed changes
Comment thread8-web-components/2-custom-elements/article.md Outdated
Dorin-David
Dorin-David reviewed Apr 3, 2021
View reviewed changes
Comment thread8-web-components/2-custom-elements/article.md Outdated
Dorin-David
Dorin-David reviewed Apr 3, 2021
View reviewed changes
Comment thread8-web-components/2-custom-elements/article.md Outdated
Dorin-David
Dorin-David reviewed Apr 3, 2021
View reviewed changes
Comment thread8-web-components/2-custom-elements/article.md Outdated
Dorin-David
Dorin-David reviewed Apr 3, 2021
View reviewed changes
Comment thread8-web-components/2-custom-elements/article.md Outdated
Dorin-David
Dorin-David reviewed Apr 3, 2021
View reviewed changes
Comment thread8-web-components/2-custom-elements/article.md Outdated
Dorin-David
Dorin-David suggested changes Apr 3, 2021
View reviewed changes

@Dorin-DavidDorin-David left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ottima traduzione! Ho corretto alcuni typo e lasciato dei piccoli suggerimenti, fanne quello che vuoi

@javascript-translate-bot

javascript-translate-bot commented Apr 3, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@longo-andrea@Dorin-David
Apply suggestions from code review
064a18d
Co-authored-by: Dorin David <70648503+Dorin-David@users.noreply.github.com>
@longo-andrea
longo-andrea merged commit 0079361 into javascript-tutorial:masterApr 5, 2021
@javascript-translate-bot

javascript-translate-bot commented Apr 5, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@longo-andrealongo-andrealongo-andrea approved these changes
+1 more reviewer
@Dorin-DavidDorin-DavidDorin-David requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2nd review doneneeds +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pierangelomiceli@javascript-translate-bot@longo-andrea@Dorin-David