Skip to content

Template element - #307

Merged
longo-andrea merged 5 commits into
javascript-tutorial:masterfrom
pierangelomiceli:027_template
Apr 27, 2021
Merged

Template element#307
longo-andrea merged 5 commits into
javascript-tutorial:masterfrom
pierangelomiceli:027_template

Conversation

@pierangelomiceli

@pierangelomicelipierangelomiceli commented Apr 20, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamApril 20, 2021 20:34
@javascript-translate-botjavascript-translate-bot mentioned this pull request Apr 20, 2021
Open
Dorin-David
Dorin-David reviewed Apr 25, 2021
View reviewed changes
Comment thread8-web-components/4-template-element/article.md Outdated
Dorin-David
Dorin-David reviewed Apr 25, 2021
View reviewed changes
Comment thread8-web-components/4-template-element/article.md Outdated
Dorin-David
Dorin-David reviewed Apr 25, 2021
View reviewed changes
Comment thread8-web-components/4-template-element/article.md
Dorin-David
Dorin-David reviewed Apr 25, 2021
View reviewed changes
Comment thread8-web-components/4-template-element/article.md Outdated
Dorin-David
Dorin-David approved these changes Apr 25, 2021
View reviewed changes

@Dorin-DavidDorin-David left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corretti alcuni typo

@pierangelomiceli@Dorin-David
Apply suggestions from code review
f22a2e3
Co-authored-by: Dorin David <70648503+Dorin-David@users.noreply.github.com>
@pierangelomiceli

pierangelomiceli commented Apr 25, 2021

Copy link
Copy Markdown
ContributorAuthor

/done

longo-andrea
longo-andrea requested changes Apr 26, 2021
View reviewed changes
Comment thread8-web-components/4-template-element/article.md Outdated
Comment thread8-web-components/4-template-element/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Apr 26, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@pierangelomiceli@longo-andrea
Apply suggestions from code review
655ae6b
Co-authored-by: Andrea <45577511+longo-andrea@users.noreply.github.com>
@pierangelomiceli

pierangelomiceli commented Apr 26, 2021

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamApril 26, 2021 19:24
@longo-andrea
longo-andrea merged commit b029232 into javascript-tutorial:masterApr 27, 2021
@javascript-translate-bot

javascript-translate-bot commented Apr 27, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@longo-andrealongo-andrealongo-andrea approved these changes
+1 more reviewer
@Dorin-DavidDorin-DavidDorin-David approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2nd review doneneeds +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pierangelomiceli@javascript-translate-bot@longo-andrea@Dorin-David