Skip to content

Character classes - #143

Closed
fsdude wants to merge 23 commits into
javascript-tutorial:masterfrom
fsdude:02-regexp-character-classes
Closed

Character classes#143
fsdude wants to merge 23 commits into
javascript-tutorial:masterfrom
fsdude:02-regexp-character-classes

Conversation

@fsdude

@fsdudefsdude commented May 25, 2020

Copy link
Copy Markdown
Contributor

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMay 25, 2020 22:27
@iliakaniliakan mentioned this pull request May 25, 2020
Open
odsantos added a commit that referenced this pull request May 26, 2020
@odsantos
Transfer translation contents#143
eaba2dc
@odsantos

odsantos commented Dec 8, 2020

Copy link
Copy Markdown
Contributor

Hi @fsdude would you please also resolve the conflicts, or kindly inform if unavailable to? Thank you.

@fsdude

fsdude commented Dec 9, 2020

Copy link
Copy Markdown
ContributorAuthor

Hi @fsdude would you please also resolve the conflicts, or kindly inform if unavailable to? Thank you.

Hello! Yeah.. lately I've been busy with some work. I don't know if I'll be able to fix this soon, sorry for that
Thanks by the way =)

@odsantos

odsantos commented Dec 9, 2020

Copy link
Copy Markdown
Contributor

@fsdude Thank you.

@CLAassistant

CLAassistant commented Dec 24, 2020•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

odsantos
odsantos requested changes May 17, 2021
View reviewed changes

@odsantosodsantos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kiniggit, @luizclr, @adriavieira314, @Mr-Saxobeat, please since @fsdude might be unavailable I would appreciate if any of you could review this PR #143 , including my revision.
Thank you.

Comment thread9-regular-expressions/02-regexp-character-classes/article.md Outdated
Comment thread9-regular-expressions/02-regexp-character-classes/article.md Outdated
Comment thread9-regular-expressions/02-regexp-character-classes/article.md Outdated
Comment thread9-regular-expressions/02-regexp-character-classes/article.md Outdated
Comment thread9-regular-expressions/02-regexp-character-classes/article.md Outdated
Comment thread9-regular-expressions/02-regexp-character-classes/article.md Outdated
Comment thread9-regular-expressions/02-regexp-character-classes/article.md Outdated
Comment thread9-regular-expressions/02-regexp-character-classes/article.md Outdated
Comment thread9-regular-expressions/02-regexp-character-classes/article.md
Comment thread9-regular-expressions/02-regexp-character-classes/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented May 17, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

odsantos
odsantos reviewed Jul 14, 2021
View reviewed changes

@odsantosodsantos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since @fsdude is not available, I applied the changes and will wait for another reviewer.

odsantos added a commit that referenced this pull request Dec 14, 2022
@odsantos
Delete solution.md
b8a8832
Update #143
@odsantos

odsantos commented Jan 23, 2023

Copy link
Copy Markdown
Contributor

Closing and re-opening a new one for resolving conflict.

@odsantosodsantos mentioned this pull request Jan 25, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odsantosodsantosodsantos requested changes

Assignees

No one assigned

Labels

review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fsdude@odsantos@CLAassistant@javascript-translate-bot