Skip to content

Ninja code - #182

Merged
gabifs merged 19 commits into
javascript-tutorial:masterfrom
Mr-Saxobeat:ninja-code
Dec 3, 2025
Merged

Ninja code#182
gabifs merged 19 commits into
javascript-tutorial:masterfrom
Mr-Saxobeat:ninja-code

Conversation

@Mr-Saxobeat

@Mr-SaxobeatMr-Saxobeat commented Oct 4, 2020

Copy link
Copy Markdown
Contributor

Translates "Ninja code" article.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamOctober 4, 2020 18:38
@javascript-translate-botjavascript-translate-bot mentioned this pull request Oct 4, 2020
Open
odsantos
odsantos requested changes Dec 30, 2020
View reviewed changes

@odsantosodsantos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mr-Saxobeat , would you please comment or consider these changes? Thank you.

Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Dec 30, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@CLAassistant

CLAassistant commented Apr 29, 2022•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@odsantos

odsantos commented Dec 12, 2022

Copy link
Copy Markdown
Contributor

Hi @Mr-Saxobeat ,

Are you still working on this?

If you're not available, I might be able to release it for another person.

Thanks,
Osvaldo.

@odsantos

odsantos commented Dec 26, 2022

Copy link
Copy Markdown
Contributor

Hi @Mr-Saxobeat ,

This PR also has conflicts after updating the article to the English version.

Thanks,
Osvaldo.

@nazarepiedady

nazarepiedady commented Mar 10, 2024

Copy link
Copy Markdown
Member

@odsantos, @jonnathan-ls, @peruibeloko, we need to resolve the conflicts of this pull request.

@nazarepiedady

nazarepiedady commented Nov 28, 2025

Copy link
Copy Markdown
Member

@gabifs

gabifsand others added 16 commits December 3, 2025 09:52
@gabifs
Merge branch 'master' into ninja-code
009ef34
@gabifs@odsantos
Update 1-js/03-code-quality/04-ninja-code/article.md
4a67602
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
@gabifs@odsantos
Update 1-js/03-code-quality/04-ninja-code/article.md
e605424
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
@gabifs@odsantos
Update 1-js/03-code-quality/04-ninja-code/article.md
9323881
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
@gabifs@odsantos
Update 1-js/03-code-quality/04-ninja-code/article.md
476e7cf
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
@gabifs@odsantos
Update 1-js/03-code-quality/04-ninja-code/article.md
e932241
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
@gabifs@odsantos
Update 1-js/03-code-quality/04-ninja-code/article.md
f0c8f5c
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
@gabifs@odsantos
Update 1-js/03-code-quality/04-ninja-code/article.md
aa4b3c7
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
@gabifs@odsantos
Update 1-js/03-code-quality/04-ninja-code/article.md
9854a49
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
@gabifs@odsantos
Update 1-js/03-code-quality/04-ninja-code/article.md
88fa30d
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
@gabifs@odsantos
Update 1-js/03-code-quality/04-ninja-code/article.md
5af2740
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
@gabifs@odsantos
Update 1-js/03-code-quality/04-ninja-code/article.md
0871d98
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
@gabifs@odsantos
Update 1-js/03-code-quality/04-ninja-code/article.md
08afe41
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
@gabifs@odsantos
Update 1-js/03-code-quality/04-ninja-code/article.md
63b59a6
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
@gabifs@odsantos
Update 1-js/03-code-quality/04-ninja-code/article.md
3a8a150
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
@gabifs@odsantos
Apply suggestions from code review
205e87f
Co-authored-by: Osvaldo Dias dos Santos <osvaldo.msdsantos@yahoo.com>
gabifs
gabifs reviewed Dec 3, 2025
View reviewed changes
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
@gabifs
gabifs merged commit 9d3c4f5 into javascript-tutorial:masterDec 3, 2025
1 check passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odsantosodsantosodsantos requested changes
@gabifsgabifsgabifs approved these changes

Assignees

No one assigned

Labels

changes requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Mr-Saxobeat@javascript-translate-bot@CLAassistant@odsantos@nazarepiedady@gabifs