Skip to content

Property flags and descriptors - #219

Merged
gabifs merged 11 commits into
javascript-tutorial:masterfrom
herbertpdl:master
Dec 2, 2025
Merged

Property flags and descriptors#219
gabifs merged 11 commits into
javascript-tutorial:masterfrom
herbertpdl:master

Conversation

@herbertpdl

@herbertpdlherbertpdl commented Jul 25, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJuly 25, 2021 19:53
@CLAassistant

CLAassistant commented Jul 25, 2021•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@javascript-translate-botjavascript-translate-bot mentioned this pull request Jul 25, 2021
Open
@herbertpdl
herbertpdlforce-pushed the master branch 2 times, most recently from 55d0244 to cabd2d8CompareJuly 25, 2021 20:09
odsantos
odsantos requested changes Jul 27, 2021
View reviewed changes

@odsantosodsantos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @herbertpdl,

Here is a review.
Please, feel free to comment where you disagree.

Thank you.

Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jul 27, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@herbertpdl

herbertpdl commented Jul 28, 2021

Copy link
Copy Markdown
ContributorAuthor

@odsantos Done!

@odsantos

odsantos commented Aug 11, 2021

Copy link
Copy Markdown
Contributor

Hi @herbertpdl , the repository was updated and this branch has conflicts, so it also needs to be updated.
If you have time to do it, could you please comment in the end here as \done only?
It is the way the bot tracks the changes and alters from changes requested to pending review.
Thank you.

@herbertpdl

herbertpdl commented Aug 13, 2021

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamAugust 13, 2021 12:40
odsantos
odsantos requested changes Aug 14, 2021
View reviewed changes

@odsantosodsantos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @herbertpdl,

Here is another review.

Thank you.

Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread1-js/07-object-properties/01-property-descriptors/article.md Outdated
Comment thread1-js/07-object-properties/01-property-descriptors/article.md
@javascript-translate-bot

javascript-translate-bot commented Aug 14, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@herbertpdl

herbertpdl commented Feb 7, 2022

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamFebruary 7, 2022 11:51
@odsantos

odsantos commented Dec 11, 2022

Copy link
Copy Markdown
Contributor

Hi @herbertpdl ,

Still working on this one.
There is conflict here.
If resolved I could try another review.

Thanks,
Osvaldo.

@nazarepiedady

nazarepiedady commented Mar 1, 2024

Copy link
Copy Markdown
Member

@peruibeloko, @jonnathan-ls, do you have time to see what is possible to do in relation to this pull request?

@peruibeloko

peruibeloko commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

@nazarepiedady his master branch is write protected, but I resolved all the conflicts here: https://github.com/Peruibeloko/pt.javascript.info/tree/herbertpdl/master

@nazarepiedady

nazarepiedady commented Mar 6, 2024

Copy link
Copy Markdown
Member

@peruibeloko, could you copy his work, review it, and create your own pull request to solve this issue?

@peruibeloko

peruibeloko commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

@nazarepiedady will do

@nazarepiedady

nazarepiedady commented Nov 28, 2025

Copy link
Copy Markdown
Member

@gabifs

@gabifs
gabifs merged commit 0424be5 into javascript-tutorial:masterDec 2, 2025
1 check passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odsantosodsantosodsantos requested changes
@gabifsgabifsgabifs approved these changes

Assignees

No one assigned

Labels

review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@herbertpdl@CLAassistant@javascript-translate-bot@odsantos@nazarepiedady@peruibeloko@gabifs