Skip to content

Scripts: async, defer - #229

Merged
nazarepiedady merged 11 commits into
javascript-tutorial:masterfrom
larissaiurk:master
Mar 17, 2024
Merged

Scripts: async, defer#229
nazarepiedady merged 11 commits into
javascript-tutorial:masterfrom
larissaiurk:master

Conversation

@larissaiurk

@larissaiurklarissaiurk commented Oct 23, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamOctober 23, 2021 03:08
@CLAassistant

CLAassistant commented Oct 23, 2021•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@javascript-translate-botjavascript-translate-bot mentioned this pull request Oct 23, 2021
Open
@odsantos

odsantos commented Dec 11, 2022

Copy link
Copy Markdown
Contributor

Hi @larissaiurk,

Still available for this task?
There is a conflict here.

Please, let me know if you have not time, and I might be able to resolve it.

Thanks,
Osvaldo.

@nazarepiedady

nazarepiedady commented Mar 1, 2024

Copy link
Copy Markdown
Member

@peruibeloko, @jonnathan-ls, do you have time to see what is possible to do in relation to this pull request?

peruibeloko
peruibeloko reviewed Mar 6, 2024
View reviewed changes
Comment thread2-ui/5-loading/02-script-async-defer/article.md Outdated
1. Scripts can't see DOM elements below them, so they can't add handlers etc.
2. If there's a bulky script at the top of the page, it "blocks the page". Users can't see the page content till it downloads and runs:
1. Os scripts não conseguem ver os elementos da DOM abaixo deles, então não conseguem manipular eventos, etc.
2. Se houver um script volumoso no topo da página, ele vai "bloqueia a página". Os usuários não podem ver o conteúdo da página até que ele faça o download e execute:

@peruibelokoperuibelokoMar 5, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Se houver um script volumoso no topo da página, ele vai "bloqueia a página". Os usuários não podem ver o conteúdo da página até que ele faça o download e execute:
2. Se houver um script volumoso no topo da página, ele vai "bloquear a página". Os usuários não podem ver o conteúdo da página até que ele faça o download e execute:

@jonnathan-lsjonnathan-lsMar 17, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ajustado

@nazarepiedady

nazarepiedady commented Mar 6, 2024•
edited
Loading

Copy link
Copy Markdown
Member

@peruibeloko, could you help to fix the conflicts, update, and approve it?

jonnathan-ls
jonnathan-ls approved these changes Mar 17, 2024
View reviewed changes

@jonnathan-lsjonnathan-ls left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I added simple adjustments (0dfdf25) and resolved the merge conflict (b0b6ae0)

@jonnathan-ls

jonnathan-ls commented Mar 17, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

... could you help to fix the conflicts, update, and approve it?

During the review, I added simple adjustments (including the suggestion requested by @peruibeloko) and also conflict resolution @nazarepiedady

/done

nazarepiedady
nazarepiedady requested changes Mar 17, 2024
View reviewed changes

@nazarepiedadynazarepiedady left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good, but there are some little changes needed.

Comment thread2-ui/5-loading/02-script-async-defer/article.md Outdated
Assim como `defer`, o atributo `async` é ignorado se a tag `<script>` não tiver `src`.
```

## Dynamic scripts

@nazarepiedadynazarepiedadyMar 17, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not translated yet.

@jonnathan-lsjonnathan-lsMar 17, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread2-ui/5-loading/02-script-async-defer/article.md Outdated

## Dynamic scripts

There's one more important way of adding a script to the page.

@nazarepiedadynazarepiedadyMar 17, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also was not translated yet.

@jonnathan-lsjonnathan-lsMar 17, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@javascript-translate-bot

javascript-translate-bot commented Mar 17, 2024

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@nazarepiedady

nazarepiedady commented Mar 17, 2024

Copy link
Copy Markdown
Member

@jonnathan-ls, there are some changes that need to be translated.

@jonnathan-ls

jonnathan-ls commented Mar 17, 2024

Copy link
Copy Markdown
Contributor

@nazarepiedady Thanks for watching, pending translation added

/done

nazarepiedady
nazarepiedady approved these changes Mar 17, 2024
View reviewed changes

@nazarepiedadynazarepiedady left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good to be applied.

@nazarepiedady
nazarepiedady merged commit dd27063 into javascript-tutorial:masterMar 17, 2024
@javascript-translate-bot

javascript-translate-bot commented Mar 17, 2024

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonnathan-lsjonnathan-lsjonnathan-ls approved these changes
@nazarepiedadynazarepiedadynazarepiedady approved these changes
@odsantosodsantosAwaiting requested review from odsantos
+1 more reviewer
@peruibelokoperuibelokoperuibeloko left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@larissaiurk@CLAassistant@odsantos@nazarepiedady@jonnathan-ls@javascript-translate-bot@peruibeloko