Skip to content

Class basic syntax - #248

Merged
nazarepiedady merged 3 commits into
javascript-tutorial:masterfrom
thiagocardoso1988:updates-class-basic-syntax
Dec 23, 2023
Merged

Class basic syntax#248
nazarepiedady merged 3 commits into
javascript-tutorial:masterfrom
thiagocardoso1988:updates-class-basic-syntax

Conversation

@thiagocardoso1988

@thiagocardoso1988thiagocardoso1988 commented Aug 17, 2022

Copy link
Copy Markdown

@javascript-translate-bot
javascript-translate-bot requested a review from a teamAugust 17, 2022 01:35
@CLAassistant

CLAassistant commented Aug 17, 2022•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jonnathan-ls
❌ Thiago Cardoso

Thiago Cardoso seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@thiagocardoso1988thiagocardoso1988 mentioned this pull request Aug 17, 2022
Open
jonnathan-ls
jonnathan-ls requested changes Aug 25, 2022
View reviewed changes
Comment thread1-js/09-classes/01-class/article.md Outdated
Comment thread1-js/09-classes/01-class/article.md Outdated
Comment thread1-js/09-classes/01-class/article.md Outdated
Comment thread1-js/09-classes/01-class/article.md Outdated
Comment thread1-js/09-classes/01-class/article.md Outdated
Comment thread1-js/09-classes/01-class/article.md Outdated
Comment thread1-js/09-classes/01-class/article.md Outdated
Comment thread1-js/09-classes/01-class/article.md Outdated
Comment thread1-js/09-classes/01-class/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Aug 25, 2022

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@jonnathan-ls
jonnathan-ls self-requested a review October 15, 2023 20:53
@jonnathan-ls

jonnathan-ls commented Oct 15, 2023

Copy link
Copy Markdown
Contributor

Olá @thiagocardoso1988, conseguiria verificar as solicitações de mudanças que registrei?

@odsantosodsantos changed the title Translates Class basic syntaxClass basic syntaxNov 18, 2023
@odsantos

odsantos commented Nov 18, 2023

Copy link
Copy Markdown
Contributor

@jonnathan-ls I updated the name of this PR and hope to check the changes as soon as possible. Thanks.

@jonnathan-ls

jonnathan-ls commented Dec 23, 2023

Copy link
Copy Markdown
Contributor

Considerando o tempo decorrido, eu adicionei as alterações que solicitei e3f4715

/done

@nazarepiedady
nazarepiedady merged commit 507d5ee into javascript-tutorial:masterDec 23, 2023
@javascript-translate-bot

javascript-translate-bot commented Dec 23, 2023

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonnathan-lsjonnathan-lsjonnathan-ls approved these changes
@nazarepiedadynazarepiedadyAwaiting requested review from nazarepiedady

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@thiagocardoso1988@CLAassistant@javascript-translate-bot@jonnathan-ls@odsantos@nazarepiedady