Uh oh!
There was an error while loading. Please reload this page.
Mixins - #382
Conversation
odsantos
commented
Mar 11, 2023
Hi @DaniloLima122 , Appreciated your efforts. Would you please follow them? |
danilolmc
commented
Mar 11, 2023
Hi @odsantos ! Thank you for the tips! Now I think the PR name is correct, according the name of the article! |
odsantos
commented
Mar 12, 2023
Hi @DaniloLima122 , it also is necessary to claim it in your name, according to the same instructions, thus you need to add a comment on that page with this title too. After that, if the bot does not reserve on your name and add this PR, a maintainer may do it manually. Thanks. |
danilolmc
commented
Mar 13, 2023
Hi @odsantos , thank you! It's done! |
odsantos
commented
Mar 13, 2023
Hi @DaniloLima122 , in the future please do not forget to claim first, then to give the PR the same name as on that page. |
danilolmc
commented
Mar 13, 2023
Hi @odsantos ! Great, I won't, thanks for your support! 😁 |
odsantos
left a comment
There was a problem hiding this comment.
Hi @danilolmc ,
Here is a review.
Please keep the translation line numbers matching the original (English) even if there is too little or too much space, and if you do not mind, also translate the text inside strings, but not variable names as you did.
Appreciate it if you tell me where you might disagree with this revision.
Thank you,
Osvaldo.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
javascript-translate-bot
commented
Mar 14, 2023
Please make the requested changes. After it, add a comment "/done". |
odsantos
commented
Mar 15, 2023
Hi @danilolmc , Here, the bot explains how to indicate that a translation is ready for another review. Your PR is still marked with "changes requested" under Labels on the top right of this page, which was done by the bot after my review. Having that label, maintainers might believe that something is still to be done, and not have a look at a PR unless much time has passed. Since you still might wish to make changes, when you have finished would you tell the bot you're done? Please, only comment with "/done" here, without quotes or anything else. Meanwhile, I am afraid I'll wait for that and the subsequent bot request for another review. Thank you, |
12ac6d5 to
787647eComparedanilolmc
commented
Mar 16, 2023
/done |
odsantos
left a comment
There was a problem hiding this comment.
Hi @danilolmc ,
We need that two maintainers review a translation for merging it.
So, we'll wait for a review by another maintainer.
Thank you,
Best wishes.
There was a problem hiding this comment.
Looks Good To Mee
@danilolmc
Thank you for contribution
javascript-translate-bot
commented
Jul 16, 2023
Error: the article has another translator @DaniloLima122, not @danilolmc in the Progress Issue #1. Please update the progress issue or ask maintainers to do so. |
jonnathan-ls
commented
Jul 16, 2023
Updated |
danilolmc
commented
Oct 28, 2023
I had changed my github username, but I had already finished the translation before it was merged. |
No description provided.