Skip to content

Class checking: "instanceof" - #398

Merged
jonnathan-ls merged 3 commits into
javascript-tutorial:masterfrom
danilolmc:update-pt-instanceof
Jul 16, 2023
Merged

Class checking: "instanceof"#398
jonnathan-ls merged 3 commits into
javascript-tutorial:masterfrom
danilolmc:update-pt-instanceof

Conversation

@danilolmc

@danilolmcdanilolmc commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMarch 14, 2023 18:12
@javascript-translate-botjavascript-translate-bot mentioned this pull request Mar 14, 2023
Open
@odsantos
Update article.md
a20f375
Remove the original English paragraph.
odsantos
odsantos requested changes Mar 16, 2023
View reviewed changes

@odsantosodsantos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @danilolmc ,

Here is a review.

"importance: 5" is not translated (the number here is only an example).

Please, do not forget to replace English hyperlinks with Portuguese ones when those are available and their explanation is good enough for being a replacement.

I appreciate it if you tell me if you disagree with any suggestion.

Thank you,
Osvaldo.

Comment thread1-js/09-classes/06-instanceof/1-strange-instanceof/solution.md Outdated
Comment thread1-js/09-classes/06-instanceof/1-strange-instanceof/solution.md Outdated
Comment thread1-js/09-classes/06-instanceof/1-strange-instanceof/task.md Outdated
Comment thread1-js/09-classes/06-instanceof/article.md Outdated
Comment thread1-js/09-classes/06-instanceof/article.md Outdated
Comment thread1-js/09-classes/06-instanceof/article.md Outdated
Comment thread1-js/09-classes/06-instanceof/article.md Outdated
Comment thread1-js/09-classes/06-instanceof/article.md Outdated
Comment thread1-js/09-classes/06-instanceof/article.md Outdated
Comment thread1-js/09-classes/06-instanceof/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Mar 16, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@danilolmc

danilolmc commented Mar 16, 2023

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMarch 16, 2023 02:18
odsantos
odsantos approved these changes Mar 16, 2023
View reviewed changes

@odsantosodsantos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @danilolmc ,

We'll need to wait for a review by another maintainer for merging this translation.

Thank you,
Best wishes.

@odsantos
odsantos marked this pull request as draft March 16, 2023 19:34
@odsantos
odsantos marked this pull request as ready for review March 16, 2023 19:35
jonnathan-ls
jonnathan-ls approved these changes Jul 16, 2023
View reviewed changes

@jonnathan-lsjonnathan-ls left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Mee

@jonnathan-ls
jonnathan-ls merged commit 887e731 into javascript-tutorial:masterJul 16, 2023
@javascript-translate-bot

javascript-translate-bot commented Jul 16, 2023

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odsantosodsantosodsantos approved these changes
@jonnathan-lsjonnathan-lsjonnathan-ls approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danilolmc@javascript-translate-bot@odsantos@jonnathan-ls