Skip to content

Async iteration and generators - #418

Merged
nazarepiedady merged 3 commits into
javascript-tutorial:masterfrom
danilolmc:async-iterators-generators
Mar 6, 2024
Merged

Async iteration and generators#418
nazarepiedady merged 3 commits into
javascript-tutorial:masterfrom
danilolmc:async-iterators-generators

Conversation

@danilolmc

@danilolmcdanilolmc commented Jan 8, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJanuary 8, 2024 15:21
@javascript-translate-botjavascript-translate-bot mentioned this pull request Jan 8, 2024
Open
nazarepiedady
nazarepiedady requested changes Feb 28, 2024
View reviewed changes

@nazarepiedadynazarepiedady left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danilolmc, could you update your pull request?

Comment thread1-js/12-generators-iterators/2-async-iterators-generators/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Feb 28, 2024

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@nazarepiedady

nazarepiedady commented Feb 28, 2024

Copy link
Copy Markdown
Member

@peruibeloko, could you do the honours?

peruibeloko
peruibeloko suggested changes Feb 28, 2024
View reviewed changes

@peruibelokoperuibeloko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Além dos comentários que deixei, senti falta de conectores como artigos em diversos pontos, como "o await", "o - async", etc. mas não acho que sejam problemas grandes demais para prejudicar a compreensão do texto

Comment thread1-js/12-generators-iterators/2-async-iterators-generators/head.html Outdated
Comment thread1-js/12-generators-iterators/2-async-iterators-generators/article.md Outdated
Comment thread1-js/12-generators-iterators/2-async-iterators-generators/article.md Outdated
Comment thread1-js/12-generators-iterators/2-async-iterators-generators/article.md Outdated
Comment thread1-js/12-generators-iterators/2-async-iterators-generators/article.md Outdated
Comment thread1-js/12-generators-iterators/2-async-iterators-generators/article.md Outdated
Comment thread1-js/12-generators-iterators/2-async-iterators-generators/article.md Outdated
Comment thread1-js/12-generators-iterators/2-async-iterators-generators/article.md Outdated
Comment thread1-js/12-generators-iterators/2-async-iterators-generators/article.md Outdated
Comment thread1-js/12-generators-iterators/2-async-iterators-generators/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Feb 28, 2024

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@danilolmc

danilolmc commented Mar 4, 2024

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMarch 4, 2024 21:06
nazarepiedady
nazarepiedady approved these changes Mar 6, 2024
View reviewed changes

@nazarepiedadynazarepiedady left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it.

@nazarepiedady
nazarepiedady merged commit 7c6f74b into javascript-tutorial:masterMar 6, 2024
@javascript-translate-bot

javascript-translate-bot commented Mar 6, 2024

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nazarepiedadynazarepiedadynazarepiedady approved these changes
@jonnathan-lsjonnathan-lsAwaiting requested review from jonnathan-ls
@murilloqualitymurilloqualityAwaiting requested review from murilloquality
@odsantosodsantosAwaiting requested review from odsantos
+1 more reviewer
@peruibelokoperuibelokoperuibeloko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danilolmc@javascript-translate-bot@nazarepiedady@peruibeloko