Skip to content

Multiline mode of anchors ^ $, flag "m" - #421

Merged
gabifs merged 5 commits into
javascript-tutorial:masterfrom
peruibeloko:09/05
Nov 25, 2025
Merged

Multiline mode of anchors ^ $, flag "m"#421
gabifs merged 5 commits into
javascript-tutorial:masterfrom
peruibeloko:09/05

Conversation

@peruibeloko

@peruibelokoperuibeloko commented Jan 17, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJanuary 17, 2024 03:23
@javascript-translate-botjavascript-translate-bot mentioned this pull request Jan 17, 2024
Open
nazarepiedady
nazarepiedady requested changes Feb 5, 2024
View reviewed changes

@nazarepiedadynazarepiedady left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peruibeloko, could you evaluate the review I did?

Comment thread9-regular-expressions/05-regexp-multiline-mode/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Feb 5, 2024

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@peruibeloko

peruibeloko commented Feb 5, 2024

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamFebruary 5, 2024 22:18
nazarepiedady
nazarepiedady approved these changes Feb 17, 2024
View reviewed changes

@nazarepiedadynazarepiedady left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ready to be applied.

@nazarepiedady

nazarepiedady commented Jun 2, 2024

Copy link
Copy Markdown
Member

@danilolmc, @jonnathan-ls, could you help to review this pull request and approve it if it is okay?

danilolmc
danilolmc reviewed Jun 10, 2024
View reviewed changes
Comment thread9-regular-expressions/05-regexp-multiline-mode/article.md Outdated
danilolmc
danilolmc reviewed Jun 10, 2024
View reviewed changes

@danilolmcdanilolmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Droped just a single comment, not a big deal!

The PR LGTM!

@peruibeloko

peruibeloko commented Jun 10, 2024

Copy link
Copy Markdown
ContributorAuthor

@nazarepiedady Implemented the change, we're able to merge now!

@nazarepiedady

nazarepiedady commented Jun 11, 2024

Copy link
Copy Markdown
Member

@peruibeloko, I need one person to approve the updates, this person does not need necessarily to be a maintainer, a regular contributor serves.

@nazarepiedady

nazarepiedady commented Aug 5, 2024

Copy link
Copy Markdown
Member

@danilolmc, do you have time to approve these updates?

@nazarepiedady

nazarepiedady commented Aug 5, 2024

Copy link
Copy Markdown
Member

@jonnathan-ls, could you approve these updates?

gabifs
gabifs approved these changes Nov 25, 2025
View reviewed changes

@gabifsgabifs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabifs
gabifs merged commit bbbad0f into javascript-tutorial:masterNov 25, 2025
@peruibeloko
peruibeloko deleted the 09/05 branch December 7, 2025 18:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabifsgabifsgabifs approved these changes
@nazarepiedadynazarepiedadynazarepiedady approved these changes
@odsantosodsantosAwaiting requested review from odsantos
@jonnathan-lsjonnathan-lsAwaiting requested review from jonnathan-ls
+1 more reviewer
@danilolmcdanilolmcdanilolmc left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@peruibeloko@javascript-translate-bot@nazarepiedady@gabifs@danilolmc