WeakMap and WeakSet - #162

Merged

tarasyyyk merged 17 commits into

javascript-tutorial:masterfrom

MykolaSopiha:weakmap-weakset

Aug 3, 2021

MykolaSopiha commented Jul 28, 2021•
edited
Loading

Collaborator

Під час перекладу помітив, що інколи назви методів перелічуються в тексті з дужками, а іноді ні. Навіть в одному і тому ж реченні. Можливо це слід обговорити та прийти до єдиного стандарту. Поки що перекладав згідно з оригіналом:

weakmap-weakset

cb04679

javascript-translate-bot added the review needed label

javascript-translate-bot mentioned this pull request

Ukrainian Translation Progress #1

Open

weakmap-weakset

d05e96c

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/08-weakmap-weakset/01-recipients-read/solution.md Outdated

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/08-weakmap-weakset/01-recipients-read/solution.md Outdated

tarasyyyk added 2 commits

July 29, 2021 20:18

Update 1-js/05-data-types/08-weakmap-weakset/01-recipients-read/solut…

de875f0

…ion.md

Update 1-js/05-data-types/08-weakmap-weakset/01-recipients-read/solut…

53ba2d7

…ion.md

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/08-weakmap-weakset/01-recipients-read/task.md Outdated

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/08-weakmap-weakset/01-recipients-read/task.md Outdated

tarasyyyk added 2 commits

July 29, 2021 20:21

Update 1-js/05-data-types/08-weakmap-weakset/01-recipients-read/task.md

3453940

Update 1-js/05-data-types/08-weakmap-weakset/01-recipients-read/task.md

dba6c68

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/08-weakmap-weakset/02-recipients-when-read/task.md Outdated

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/08-weakmap-weakset/02-recipients-when-read/task.md Outdated

tarasyyyk added 2 commits

July 29, 2021 20:23

Update 1-js/05-data-types/08-weakmap-weakset/02-recipients-when-read/…

559276e

…task.md

Update 1-js/05-data-types/08-weakmap-weakset/02-recipients-when-read/…

2905374

…task.md

tarasyyyk requested changes

View reviewed changes

tarasyyyk left a comment

Collaborator

Дуже добре. Є декілька невеличких правок. Я вже додав пропозиції, тож залишилося лише їх закомітити. На рахунок назв методів. Про це не переймайтеся – пізніше в англійському варіанті їх заберуть і я оновлю переклад.

1-js/05-data-types/08-weakmap-weakset/article.md Outdated

1-js/05-data-types/08-weakmap-weakset/article.md Outdated

1-js/05-data-types/08-weakmap-weakset/article.md Outdated

1-js/05-data-types/08-weakmap-weakset/article.md Outdated

1-js/05-data-types/08-weakmap-weakset/article.md Outdated

1-js/05-data-types/08-weakmap-weakset/article.md Outdated

1-js/05-data-types/08-weakmap-weakset/article.md Outdated

javascript-translate-bot removed the review needed label

javascript-translate-bot commented Jul 29, 2021

Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

javascript-translate-bot added the changes requested label

MykolaSopihaand others added 9 commits

July 29, 2021 22:59

weakmap-weakset

eb1c521

Update 1-js/05-data-types/08-weakmap-weakset/article.md

11577f6

Co-authored-by: Taras <oster.ok@gmail.com>

Update 1-js/05-data-types/08-weakmap-weakset/article.md

fb97f49

Co-authored-by: Taras <oster.ok@gmail.com>

Update 1-js/05-data-types/08-weakmap-weakset/article.md

2d442b9

Co-authored-by: Taras <oster.ok@gmail.com>

Update 1-js/05-data-types/08-weakmap-weakset/article.md

b57764a

Co-authored-by: Taras <oster.ok@gmail.com>

Update 1-js/05-data-types/08-weakmap-weakset/article.md

419af44

Co-authored-by: Taras <oster.ok@gmail.com>

Update 1-js/05-data-types/08-weakmap-weakset/article.md

8dac342

Co-authored-by: Taras <oster.ok@gmail.com>

Update 1-js/05-data-types/08-weakmap-weakset/article.md

f5eb970

Co-authored-by: Taras <oster.ok@gmail.com>

Merge branch 'weakmap-weakset' of github.com:MykolaSopiha/uk.javascri…

44c5f94

…pt.info into weakmap-weakset

MykolaSopiha commented Jul 29, 2021

CollaboratorAuthor

@tarasyyyk дякую за правки! Я їх закомітив + додав ще пару невеликих фіксів. Сподіваюсь тепер все ок)

MykolaSopiha commented Aug 1, 2021

CollaboratorAuthor

/done

javascript-translate-bot added review needed and removed changes requested labels

tarasyyyk commented Aug 3, 2021

Collaborator

@MykolaSopiha чудово! Вибачте за затримку. Зараз в мене обмаль часу на перевірки.
Переклад підтверджую.

tarasyyyk approved these changes

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels

tarasyyyk merged commit 89ee8e9 into javascript-tutorial:master

javascript-translate-bot commented Aug 3, 2021

Contributor

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment