Skip to content

Modifying the document - #299

Merged
MykolaSopiha merged 222 commits into
javascript-tutorial:masterfrom
malechaneit:modifying-the-document
Feb 17, 2022
Merged

Modifying the document#299
MykolaSopiha merged 222 commits into
javascript-tutorial:masterfrom
malechaneit:modifying-the-document

Conversation

@malechaneit

@malechaneitmalechaneit commented Jan 27, 2022

Copy link
Copy Markdown
Contributor

Перекладено все, включаючи завдання та текст для svg. Але новий файл before-prepend-append-after.svg не змогла згенерувати (помилки в консолі)

@CLAassistant

CLAassistant commented Jan 27, 2022•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@javascript-translate-botjavascript-translate-bot mentioned this pull request Jan 27, 2022
Open
@dolgachio

dolgachio commented Jan 28, 2022

Copy link
Copy Markdown
Collaborator

@malechaneit дякуємо за переклад! Щоб ми змогли його прийняти, будь ласка, підпишіть Contributor License Agreement. Там є повідомлення від бота:

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

MykolaSopiha
MykolaSopiha requested changes Jan 30, 2022
View reviewed changes
Comment thread2-ui/1-document/07-modifying-document/4-clear-elem/solution.md
Comment thread2-ui/1-document/07-modifying-document/4-clear-elem/task.md Outdated
Comment thread2-ui/1-document/07-modifying-document/6-create-list/solution.view/index.html
Comment thread2-ui/1-document/07-modifying-document/7-create-object-tree/build-tree-dom.view/index.html
Comment thread2-ui/1-document/07-modifying-document/7-create-object-tree/build-tree-dom.view/index.html
Comment thread2-ui/1-document/07-modifying-document/9-calendar-table/solution.view/index.html Outdated
Comment thread2-ui/1-document/07-modifying-document/article.md Outdated
Comment thread2-ui/1-document/07-modifying-document/article.md Outdated
Comment thread2-ui/1-document/07-modifying-document/article.md Outdated
Comment thread2-ui/1-document/07-modifying-document/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jan 30, 2022

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

MykolaSopiha
MykolaSopiha requested changes Jan 30, 2022
View reviewed changes
Comment thread2-ui/1-document/07-modifying-document/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jan 30, 2022

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

MykolaSopiha
MykolaSopiha requested changes Jan 30, 2022
View reviewed changes
Comment thread2-ui/1-document/07-modifying-document/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jan 30, 2022

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

MykolaSopiha
MykolaSopiha requested changes Jan 30, 2022
View reviewed changes
Comment thread2-ui/1-document/07-modifying-document/article.md
Comment thread2-ui/1-document/07-modifying-document/article.md
Comment thread2-ui/1-document/07-modifying-document/article.md
@javascript-translate-bot

javascript-translate-bot commented Jan 30, 2022

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

MykolaSopiha
MykolaSopiha requested changes Jan 30, 2022
View reviewed changes
Comment thread2-ui/1-document/07-modifying-document/article.md
@javascript-translate-bot

javascript-translate-bot commented Jan 30, 2022

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@malechaneit

malechaneit commented Jan 31, 2022

Copy link
Copy Markdown
ContributorAuthor

@malechaneit дякуємо за переклад! Щоб ми змогли його прийняти, будь ласка, підпишіть Contributor License Agreement. Там є повідомлення від бота:

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

Підписала від імені @malechaneit, а от як це зробити від Vita Chukhno не розумію.

@dolgachio

dolgachio commented Jan 31, 2022

Copy link
Copy Markdown
Collaborator

@malechaneit судячи з всього, вам потрібно додати email, який ви використовували для цього комміту (Vita Chukhno) до свого аккаунту в ГітХаб.

@malechaneit

malechaneit commented Jan 31, 2022

Copy link
Copy Markdown
ContributorAuthor

@malechaneit судячи з всього, вам потрібно додати email, який ви використовували для цього комміту (Vita Chukhno) до свого аккаунту в ГітХаб.

Так, вже зробила. Але попередні коміти так і залишаться без мейлу, якщо не відредагувати інформацію про автора в конкретному коміті. Без підпису Vita Chukhno мердж буде неможливий?

malechaneitand others added 10 commits February 2, 2022 16:42
MykolaSopiha
MykolaSopiha approved these changes Feb 17, 2022
View reviewed changes
Comment thread1-js/02-first-steps/02-structure/article.md Outdated
@MykolaSopiha
Update 1-js/02-first-steps/02-structure/article.md
6513f2b
@MykolaSopiha
Update 2-ui/1-document/07-modifying-document/article.md
824f4d7
@MykolaSopiha
Update 2-ui/1-document/07-modifying-document/article.md
85fd950
@MykolaSopiha
Update 2-ui/1-document/07-modifying-document/article.md
e2c2ef3
@MykolaSopiha
Update 2-ui/2-events/04-default-browser-action/article.md
b471499
@MykolaSopiha
Update 2-ui/1-document/07-modifying-document/article.md
568eb42
@MykolaSopiha
Update 2-ui/1-document/07-modifying-document/article.md
60bce46
@MykolaSopiha
Update 2-ui/2-events/04-default-browser-action/article.md
f291b4b
@MykolaSopiha
Update 2-ui/2-events/04-default-browser-action/article.md
3a1a92d
@MykolaSopiha
Update 2-ui/2-events/04-default-browser-action/article.md
959eeb2
@MykolaSopiha
Update 2-ui/2-events/04-default-browser-action/article.md
dc370e6
@MykolaSopiha
Update 2-ui/2-events/04-default-browser-action/article.md
31bae74
@MykolaSopiha
Update 2-ui/1-document/07-modifying-document/article.md
da695ee
@MykolaSopiha
Update 2-ui/1-document/07-modifying-document/article.md
a261124
@MykolaSopiha
Update 2-ui/1-document/07-modifying-document/article.md
96d5a6d
@MykolaSopiha
Update 2-ui/1-document/07-modifying-document/article.md
6abf32d
@MykolaSopiha
Merge branch 'master' into modifying-the-document
28d5015
@MykolaSopiha
MykolaSopiha merged commit 8054efd into javascript-tutorial:masterFeb 17, 2022
@javascript-translate-bot

javascript-translate-bot commented Feb 17, 2022

Copy link
Copy Markdown
Contributor

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MykolaSopihaMykolaSopihaMykolaSopiha approved these changes

Assignees

No one assigned

Labels

needs +1partially reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

13 participants

@malechaneit@CLAassistant@dolgachio@javascript-translate-bot@MykolaSopiha@Purusah@NickFallman@hordiienko-tatiana@OlhaBrozhenets@tarasyyyk@Mouu9@jeneg@Nordtonito