Skip to content

Drag'n'Drop with mouse events - #322

Merged
dolgachio merged 13 commits into
javascript-tutorial:masterfrom
AntonBurchak:drag-n-drop
Mar 26, 2022
Merged

Drag'n'Drop with mouse events#322
dolgachio merged 13 commits into
javascript-tutorial:masterfrom
AntonBurchak:drag-n-drop

Conversation

@AntonBurchak

@AntonBurchakAntonBurchak commented Feb 23, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-botjavascript-translate-bot mentioned this pull request Feb 23, 2022
Open
@CLAassistant

CLAassistant commented Feb 23, 2022

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ AntonBurchak
❌ Anton_Burchak

Anton_Burchak seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@AntonBurchak

AntonBurchak commented Feb 23, 2022

Copy link
Copy Markdown
ContributorAuthor

@tarasyyyk Можеш будь-ласка подивитись?)

@dolgachio

dolgachio commented Mar 13, 2022

Copy link
Copy Markdown
Collaborator

@AntonBurchak привіт, для комітів у цьому пулл реквесті ви використала два різні аккаунти:
✅ AntonBurchak
❌ Anton_Burchak
Для того, щоб ми могли прийняти пулл реквест, потрібно додати другого користувача до вашого GitHub аккаунту

@dolgachiodolgachio added the in progress Translation in progress label Mar 13, 2022
@dolgachio
dolgachio self-requested a review March 13, 2022 22:23
dolgachio
dolgachio requested changes Mar 21, 2022
View reviewed changes

@dolgachiodolgachio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дякую за чудовий переклад! Будя ласка, подивіться на мої коментарі.
Звертаю вашу увагу, що я ще не закінчиві переверку, завершу сьогодні ;)

Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/1-slider/solution.md Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/1-slider/task.md Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/1-slider/solution.md Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/1-slider/solution.view/index.html Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/2-drag-heroes/solution.md Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/2-drag-heroes/solution.view/soccer.js Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/2-drag-heroes/solution.view/soccer.js Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/2-drag-heroes/source.view/index.html Outdated

<p>And one more thing: heroes may never leave the page. If they reach the edge of the document, no dragging outside of it.</p>

<h2>Розставте супергероїв по полю.</h2>

@dolgachiodolgachioMar 21, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Будь ласка, змініть цей файл, відповідно до моїх коменьтарів вище

Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/2-drag-heroes/solution.view/index.html Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/2-drag-heroes/task.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Mar 21, 2022

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

dolgachio
dolgachio requested changes Mar 21, 2022
View reviewed changes
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/article.md Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/article.md Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/article.md Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/article.md Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/article.md Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/article.md Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/article.md Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/article.md Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/article.md Outdated
Comment thread2-ui/3-event-details/4-mouse-drag-and-drop/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Mar 21, 2022

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@dolgachiodolgachio removed partially reviewed in progress Translation in progress labels Mar 21, 2022
@AntonBurchak

AntonBurchak commented Mar 22, 2022

Copy link
Copy Markdown
ContributorAuthor

@stas-dolgachov Дякую за ретельне ревью. Я вніс корективи до перекладу, будь-ласка перевірте

@AntonBurchak

AntonBurchak commented Mar 25, 2022

Copy link
Copy Markdown
ContributorAuthor

/done

@dolgachio

dolgachio commented Mar 26, 2022

Copy link
Copy Markdown
Collaborator

Дякую за чудовий переклад!

@dolgachio
dolgachio merged commit 8a8d92e into javascript-tutorial:masterMar 26, 2022
@javascript-translate-bot

javascript-translate-bot commented Mar 26, 2022

Copy link
Copy Markdown
Contributor

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dolgachiodolgachiodolgachio approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AntonBurchak@CLAassistant@dolgachio@javascript-translate-bot