Skip to content

Capturing groups - #441

Merged
dolgachio merged 2 commits into
javascript-tutorial:masterfrom
SamGreenberg:capturing-groups
Mar 25, 2023
Merged

Capturing groups#441
dolgachio merged 2 commits into
javascript-tutorial:masterfrom
SamGreenberg:capturing-groups

Conversation

@SamGreenberg

@SamGreenbergSamGreenberg commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-botjavascript-translate-bot mentioned this pull request Jan 11, 2023
Open
dolgachio
dolgachio requested changes Mar 25, 2023
View reviewed changes

@dolgachiodolgachio left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дякую за переклад і ваш внесок! Я додав кілька коментарів до тексту, з вашого боку нічого більше не треба, я сам внесу необхідні зміни

Comment thread9-regular-expressions/11-regexp-groups/01-test-mac/solution.md Outdated
Comment thread9-regular-expressions/11-regexp-groups/01-test-mac/solution.md Outdated
Comment thread9-regular-expressions/11-regexp-groups/01-test-mac/task.md Outdated
Comment thread9-regular-expressions/11-regexp-groups/02-find-webcolor-3-or-6/solution.md Outdated
Comment thread9-regular-expressions/11-regexp-groups/02-find-webcolor-3-or-6/solution.md Outdated
Comment thread9-regular-expressions/11-regexp-groups/article.md Outdated

```js run
let str = "Gogogo John!";
let str = "Gogogo Іван!";

@dolgachiodolgachioMar 25, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let str = "Gogogo Іван!";
let str = "Gogogo John!";

Comment thread9-regular-expressions/11-regexp-groups/article.md Outdated
alert( result[0] ); // Gogogo John (full match)
alert( result[1] ); // John
alert( result.length ); // 2 (no more items in the array)
alert( result[0] ); // Gogogo Іван (повний збіг)

@dolgachiodolgachioMar 25, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
alert( result[0] ); // Gogogo Іван (повний збіг)
alert( result[0] ); // Gogogo John (повний збіг)

Comment thread9-regular-expressions/11-regexp-groups/article.md Outdated
alert( result[1] ); // John
alert( result.length ); // 2 (no more items in the array)
alert( result[0] ); // Gogogo Іван (повний збіг)
alert( result[1] ); // Іван

@dolgachiodolgachioMar 25, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
alert( result[1] ); // Іван
alert( result[1] ); // John

Comment thread9-regular-expressions/11-regexp-groups/article.md Outdated
alert( result.length ); // 2 (no more items in the array)
alert( result[0] ); // Gogogo Іван (повний збіг)
alert( result[1] ); // Іван
alert( result.length ); // 2 (інших елементів у масиві нема)

@dolgachiodolgachioMar 25, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
alert( result.length ); // 2 (інших елементів у масиві нема)
alert( result.length ); // 2 (інших елементів у масиві немає)

Comment thread9-regular-expressions/11-regexp-groups/article.md Outdated

- The method `str.match` returns capturing groups only without flag `pattern:g`.
- The method `str.matchAll` always returns capturing groups.
- Метод `str.match` повертає групи захоплення лише без прапору `pattern:g`.

@dolgachiodolgachioMar 25, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Метод `str.match` повертає групи захоплення лише без прапору`pattern:g`.
- Метод `str.match` повертає групи захоплення лише без прапорцю`pattern:g`.

@javascript-translate-bot

javascript-translate-bot commented Mar 25, 2023

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@dolgachio

dolgachio commented Mar 25, 2023

Copy link
Copy Markdown
Collaborator

@all-contributors add @SamGreenberg for translation

@allcontributors

allcontributorsBot commented Mar 25, 2023

Copy link
Copy Markdown
Contributor

@stas-dolgachov

@SamGreenberg already contributed before to translation

@dolgachio
dolgachio merged commit 0dc4838 into javascript-tutorial:masterMar 25, 2023
@javascript-translate-bot

javascript-translate-bot commented Mar 25, 2023

Copy link
Copy Markdown
Contributor

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dolgachiodolgachiodolgachio approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SamGreenberg@javascript-translate-bot@dolgachio