Skip to content

Ninja Code - #61

Merged
tarasyyyk merged 17 commits into
javascript-tutorial:masterfrom
alexgalkin:translate/ninjacode
Mar 1, 2020
Merged

Ninja Code#61
tarasyyyk merged 17 commits into
javascript-tutorial:masterfrom
alexgalkin:translate/ninjacode

Conversation

@alexgalkin

@alexgalkinalexgalkin commented Mar 1, 2020

Copy link
Copy Markdown
Contributor

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMarch 1, 2020 10:52
tarasyyyk
tarasyyyk requested changes Mar 1, 2020
View reviewed changes

@tarasyyyktarasyyyk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Please, made small corrections before merge.

Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md
Скажіть йому, що коротше - це завжди краще. Допоможіть і йому стати на шлях ніндзя.

## One-letter variables
## Однолітерні змінні

@tarasyyyktarasyyykMar 1, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Чи існує в українській мові слово «однолітерні»?

@alexgalkinalexgalkinMar 1, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarasyyyk , так, існує.
http://194.44.152.155/elib/local/sk741783.pdf
"Українська мова в професійній діяльності" Київ, "Вища школа", 2006 р. Там слова "однолітерний", "однолітерні" зустрічаються.

Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Mar 1, 2020

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

alexgalkinand others added 9 commits March 1, 2020 16:40
@alexgalkin@tarasyyyk
Update 1-js/03-code-quality/04-ninja-code/article.md
a3137c4
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin@tarasyyyk
Update 1-js/03-code-quality/04-ninja-code/article.md
a2c6a38
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin@tarasyyyk
Update 1-js/03-code-quality/04-ninja-code/article.md
e5cda04
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin@tarasyyyk
Update 1-js/03-code-quality/04-ninja-code/article.md
be31873
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin@tarasyyyk
Update 1-js/03-code-quality/04-ninja-code/article.md
7a68b23
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin@tarasyyyk
Update 1-js/03-code-quality/04-ninja-code/article.md
6f1c48a
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin@tarasyyyk
Update 1-js/03-code-quality/04-ninja-code/article.md
0cdb769
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin@tarasyyyk
Update 1-js/03-code-quality/04-ninja-code/article.md
837ccce
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin@tarasyyyk
Update 1-js/03-code-quality/04-ninja-code/article.md
fff2c54
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin

alexgalkin commented Mar 1, 2020

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMarch 1, 2020 14:51
@alexgalkin
alexgalkin requested review from tarasyyyk and removed request for a teamMarch 1, 2020 14:51
@tarasyyyk
tarasyyyk merged commit 348f568 into javascript-tutorial:masterMar 1, 2020
@iliakaniliakan mentioned this pull request Mar 1, 2020
Open
@tarasyyyk

tarasyyyk commented Mar 6, 2020

Copy link
Copy Markdown
Collaborator

Thanks for your contribution!
@all-contributors add @alexgalkin for translation.

@allcontributorsallcontributorsBot mentioned this pull request Mar 6, 2020
Merged
@allcontributors

allcontributorsBot commented Mar 6, 2020

Copy link
Copy Markdown
Contributor

@tarasyyyk

I've put up a pull request to add @alexgalkin! 🎉

@tarasyyyktarasyyyk changed the title Translate for "Ninja Code" sectionNinja CodeAug 29, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarasyyyktarasyyykAwaiting requested review from tarasyyyk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexgalkin@javascript-translate-bot@tarasyyyk