Skip to content

Loops: while, for - #77

Merged
tarasyyyk merged 3 commits into
javascript-tutorial:translate-loopsfrom
dDenysS:master
Mar 12, 2020
Merged

Loops: while, for#77
tarasyyyk merged 3 commits into
javascript-tutorial:translate-loopsfrom
dDenysS:master

Conversation

@dDenysS

@dDenysSdDenysS commented Mar 7, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamMarch 7, 2020 15:38
alexgalkin
alexgalkin reviewed Mar 7, 2020
View reviewed changes
Comment thread1-js/02-first-steps/12-while-for/article.md Outdated
alexgalkin
alexgalkin reviewed Mar 7, 2020
View reviewed changes
Comment thread1-js/02-first-steps/12-while-for/article.md
alexgalkin
alexgalkin reviewed Mar 7, 2020
View reviewed changes
Comment thread1-js/02-first-steps/12-while-for/article.md
alexgalkin
alexgalkin reviewed Mar 7, 2020
View reviewed changes
Comment thread1-js/02-first-steps/12-while-for/article.md
alexgalkin
alexgalkin reviewed Mar 7, 2020
View reviewed changes
Comment thread1-js/02-first-steps/12-while-for/article.md
alexgalkin
alexgalkin reviewed Mar 7, 2020
View reviewed changes
Comment thread1-js/02-first-steps/12-while-for/article.md
alexgalkin
alexgalkin reviewed Mar 7, 2020
View reviewed changes
Comment thread1-js/02-first-steps/12-while-for/article.md
alexgalkin
alexgalkin reviewed Mar 7, 2020
View reviewed changes
Comment thread1-js/02-first-steps/12-while-for/article.md Outdated
alexgalkin
alexgalkin suggested changes Mar 7, 2020
View reviewed changes

@alexgalkinalexgalkin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation. I have added a few suggestions.

@javascript-translate-bot

javascript-translate-bot commented Mar 7, 2020

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@alexgalkin

alexgalkin commented Mar 7, 2020

Copy link
Copy Markdown
Contributor

@dDenysS besides translation suggestions there is also a conflict. Please resolve that. Thanks.

@tarasyyyk

tarasyyyk commented Mar 7, 2020

Copy link
Copy Markdown
Collaborator

Please resolve that

@alexgalkin no need. Thanks for review. I'll handle this PR later.

dDenysSand others added 2 commits March 8, 2020 20:13
@dDenysS@alexgalkin
Update 1-js/02-first-steps/12-while-for/article.md
742be10
Co-Authored-By: Alex Galkin <alexgalkin@users.noreply.github.com>
@dDenysS
Merge branch 'master' into master
e0f4807
@tarasyyyk
tarasyyyk changed the base branch from master to translate-loopsMarch 12, 2020 20:37
@tarasyyyk
tarasyyyk merged commit 330d278 into javascript-tutorial:translate-loopsMar 12, 2020
@tarasyyyktarasyyyk mentioned this pull request Mar 12, 2020
Merged
@tarasyyyk

tarasyyyk commented Mar 12, 2020

Copy link
Copy Markdown
Collaborator

Translation continued in #78.

@tarasyyyktarasyyyk mentioned this pull request Sep 14, 2020
Open
@tarasyyyktarasyyyk changed the title Translate:12-while-forLoops: while, forAug 29, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@alexgalkinalexgalkinalexgalkin requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dDenysS@javascript-translate-bot@alexgalkin@tarasyyyk