Skip to content

Coding Style - #174

Merged
tunggnu merged 25 commits into
javascript-tutorial:masterfrom
ImVietnam:patch-2
Jun 8, 2023
Merged

Coding Style#174
tunggnu merged 25 commits into
javascript-tutorial:masterfrom
ImVietnam:patch-2

Conversation

@ImVietnam

@ImVietnamImVietnam commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-botjavascript-translate-bot mentioned this pull request Feb 21, 2023
Open
henryonsoftware
henryonsoftware suggested changes Feb 23, 2023
View reviewed changes
Comment thread1-js/03-code-quality/02-coding-style/1-style-errors/solution.md Outdated
Comment thread1-js/03-code-quality/02-coding-style/1-style-errors/task.md Outdated
Comment thread1-js/03-code-quality/02-coding-style/1-style-errors/task.md Outdated
Comment thread1-js/03-code-quality/02-coding-style/article.md Outdated
Comment thread1-js/03-code-quality/02-coding-style/article.md Outdated
Comment thread1-js/03-code-quality/02-coding-style/article.md Outdated
Comment thread1-js/03-code-quality/02-coding-style/article.md Outdated
Comment thread1-js/03-code-quality/02-coding-style/article.md Outdated
Comment thread1-js/03-code-quality/02-coding-style/article.md Outdated
Comment thread1-js/03-code-quality/02-coding-style/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Feb 23, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@ImVietnam

ImVietnam commented Feb 25, 2023

Copy link
Copy Markdown
ContributorAuthor

/done

@ImVietnam

ImVietnam commented Mar 1, 2023

Copy link
Copy Markdown
ContributorAuthor

/done

henryonsoftware
henryonsoftware approved these changes Mar 1, 2023
View reviewed changes

@henryonsoftwarehenryonsoftware left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tunggnu
tunggnu requested changes Jun 8, 2023
View reviewed changes
Comment thread1-js/03-code-quality/02-coding-style/1-style-errors/solution.md Outdated
Comment thread1-js/03-code-quality/02-coding-style/1-style-errors/solution.md Outdated
Comment thread1-js/03-code-quality/02-coding-style/1-style-errors/task.md Outdated
Comment thread1-js/03-code-quality/02-coding-style/article.md Outdated
Comment thread1-js/03-code-quality/02-coding-style/article.md Outdated
Comment thread1-js/03-code-quality/02-coding-style/article.md Outdated
Comment thread1-js/03-code-quality/02-coding-style/article.md Outdated
Comment thread1-js/03-code-quality/02-coding-style/article.md Outdated
Comment thread1-js/03-code-quality/02-coding-style/article.md Outdated
Comment thread1-js/03-code-quality/02-coding-style/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jun 8, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@ImVietnam

ImVietnam commented Jun 8, 2023

Copy link
Copy Markdown
ContributorAuthor

/done

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJune 8, 2023 05:30
tunggnu
tunggnu approved these changes Jun 8, 2023
View reviewed changes

@tunggnutunggnu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@tunggnu
tunggnu merged commit 94a73bd into javascript-tutorial:masterJun 8, 2023
@javascript-translate-bot

javascript-translate-bot commented Jun 8, 2023

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tunggnutunggnutunggnu approved these changes
+1 more reviewer
@henryonsoftwarehenryonsoftwarehenryonsoftware approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ImVietnam@javascript-translate-bot@tunggnu@henryonsoftware