Skip to content

Ninja code - #175

Merged
henryonsoftware merged 4 commits into
javascript-tutorial:masterfrom
ImVietnam:patch-3
Feb 28, 2023
Merged

Ninja code#175
henryonsoftware merged 4 commits into
javascript-tutorial:masterfrom
ImVietnam:patch-3

Conversation

@ImVietnam

@ImVietnamImVietnam commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-botjavascript-translate-bot mentioned this pull request Feb 21, 2023
Open
henryonsoftware
henryonsoftware reviewed Feb 23, 2023
View reviewed changes
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
Comment thread1-js/03-code-quality/04-ninja-code/article.md Outdated
tunggnu
tunggnu requested changes Feb 27, 2023
View reviewed changes

@tunggnutunggnu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ImVietnam bạn xem lại các nhận xét và cập nhật lại bản dịch nhé.

@javascript-translate-bot

javascript-translate-bot commented Feb 27, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@ImVietnam

ImVietnam commented Feb 28, 2023

Copy link
Copy Markdown
ContributorAuthor

/done

tunggnu
tunggnu approved these changes Feb 28, 2023
View reviewed changes

@tunggnutunggnu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@ImVietnam

ImVietnam commented Feb 28, 2023

Copy link
Copy Markdown
ContributorAuthor

thx

henryonsoftware
henryonsoftware approved these changes Feb 28, 2023
View reviewed changes

@henryonsoftwarehenryonsoftware left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@henryonsoftware
henryonsoftware merged commit f604507 into javascript-tutorial:masterFeb 28, 2023
@javascript-translate-bot

javascript-translate-bot commented Feb 28, 2023

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@ImVietnam
ImVietnam deleted the patch-3 branch March 1, 2023 01:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tunggnutunggnutunggnu approved these changes
+1 more reviewer
@henryonsoftwarehenryonsoftwarehenryonsoftware approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ImVietnam@javascript-translate-bot@tunggnu@henryonsoftware