Skip to content

Functions - #222

Merged
tunggnu merged 5 commits into
javascript-tutorial:masterfrom
hoangnv170752:master
Jul 15, 2024
Merged

Functions#222
tunggnu merged 5 commits into
javascript-tutorial:masterfrom
hoangnv170752:master

Conversation

@hoangnv170752

@hoangnv170752hoangnv170752 commented Jul 13, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot
javascript-translate-bot requested a review from a teamJuly 13, 2024 07:10
@CLAassistant

CLAassistant commented Jul 13, 2024•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@javascript-translate-botjavascript-translate-bot mentioned this pull request Jul 13, 2024
Open
@hoangnv170752

hoangnv170752 commented Jul 13, 2024

Copy link
Copy Markdown
ContributorAuthor

@tunggnu & @henryonsoftware xin phép ping các anh về phần review và merge ạ

tunggnu
tunggnu requested changes Jul 13, 2024
View reviewed changes
Comment thread1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread1-js/02-first-steps/15-function-basics/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jul 13, 2024

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@tunggnu

tunggnu commented Jul 13, 2024

Copy link
Copy Markdown
Contributor

@hoangnv170752 bạn cần ký thỏa thuận tác quyền ở link này #222 (comment)

hoangnv170752
hoangnv170752 commented Jul 13, 2024
View reviewed changes

@hoangnv170752hoangnv170752 left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Em có đẩy 1 commit mới sửa các lỗi dịch ạ

@tunggnutunggnu self-assigned this Jul 13, 2024
tunggnu
tunggnu requested changes Jul 13, 2024
View reviewed changes
Comment thread1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread1-js/02-first-steps/15-function-basics/1-if-else-required/task.md Outdated
Comment thread1-js/02-first-steps/15-function-basics/3-min/solution.md Outdated
Comment thread1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread1-js/02-first-steps/15-function-basics/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jul 13, 2024

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

tunggnu
tunggnu requested changes Jul 14, 2024
View reviewed changes
Comment thread1-js/02-first-steps/15-function-basics/article.md Outdated
Comment thread1-js/02-first-steps/15-function-basics/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jul 14, 2024

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@tunggnu

tunggnu commented Jul 14, 2024

Copy link
Copy Markdown
Contributor

@hoangnv170752 bạn xem lại 3 bình luận của mình ở trên để sửa nội dung tương ứng, sửa xong cái nào bạn bấm Resolve conversation để đóng bình luận đó lại.

@tunggnu

tunggnu commented Jul 15, 2024

Copy link
Copy Markdown
Contributor

@hoangnv170752 còn bình luận này bạn chưa xử lý #222 (comment)

@hoangnv170752

hoangnv170752 commented Jul 15, 2024

Copy link
Copy Markdown
ContributorAuthor

Em đã hoàn thiện ạ @tunggnu

@tunggnu
tunggnu merged commit 3c4c432 into javascript-tutorial:masterJul 15, 2024
@javascript-translate-bot

javascript-translate-bot commented Jul 15, 2024

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tunggnutunggnutunggnu approved these changes

Assignees

@tunggnutunggnu

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hoangnv170752@CLAassistant@javascript-translate-bot@tunggnu