ArrayBuffer, binary arrays · Pull Request #529 · javascript-tutorial/zh.javascript.info

ghost · 2019-11-20T15:01:54Z

目标章节：4-binary/01-arraybuffer-binary-arrays

当前上游最新 commit：54984506

所做更改如下：

文件名	参考上游 commit	更改（理由）
article.md	c5ce557	新增翻译文件
o1-concat/task.md	6fb4aab	新增翻译文件
_js.view/solution.js	6fb4aab	新增翻译文件
_js.view/source.js	6fb4aab	新增翻译文件

KerbalHao · 2019-11-30T07:26:58Z

还请麻烦您修改一下 PR 内容，写上修改的文件和参考的上游 commit 等

javascript-translate-bot · 2019-11-30T08:06:13Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

ghost · 2019-11-30T13:13:06Z

还请麻烦您修改一下 PR 内容，写上修改的文件和参考的上游 commit 等

已修改，谢谢~

/done

KerbalHao

感谢翻译，校对完毕

ghost · 2019-12-02T12:29:30Z

感谢校对，已修改~

/done

leviding

存在几点问题，麻烦译者 @bemself 注意一下，并进行修改：

格式细节问题需要仔细
翻译成中文的，那就不要用英文的引号来扩中文汉字，符号也要相应改为中文全角
空格等细节格式问题
168 行的 2<sup>8</sup> 是 2⁸，也就是 2 的八次方，不是取余吧？

@KerbalHao 麻烦校对者也注意，在审核翻译的同时，也要审核格式问题。

javascript-translate-bot · 2019-12-04T02:36:41Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

leviding · 2019-12-04T02:39:26Z

麻烦两位 @bemself @KerbalHao 都看下校对意见，现根据校对意见修改一遍，修改的同时需要检查是否还有类似问题，一并修改，辛苦了。

resolve review comment Co-Authored-By: LeviDing <imdingxuewen@gmail.com>

Co-Authored-By: LeviDing <imdingxuewen@gmail.com>

ghost · 2019-12-04T14:56:27Z

@leviding 感谢校对，已修改~

/done

ghost · 2019-12-05T12:26:02Z

@KerbalHao 感谢校对，已修改。

/done

javascript-translate-bot · 2019-12-05T12:32:01Z

Error: the article already translated in the Progress Issue #324⁉️

bemself added 5 commits November 19, 2019 22:36

init trans of array buffer
4d05ad9

update trans for array buffer article
6274765

arraybuffer: minor update
aea3dce

arraybuffer: update task md
853a9b6

arraybuffer: add trans for solution js
d3f39b2

javascript-translate-bot added the review needed label Nov 20, 2019

javascript-translate-bot requested a review from a teamNovember 20, 2019 15:01

iliakan mentioned this pull request Nov 20, 2019
Chinese Translation Progress #324
Closed

ghost changed the title ~~ArrayBuffer, binary arrays~~[WIP] ArrayBuffer, binary arraysNov 29, 2019

ghost force-pushed the master branch from 2080548 to d3f39b2Compare November 29, 2019 15:47

ghost changed the title ~~[WIP] ArrayBuffer, binary arrays~~ArrayBuffer, binary arraysNov 29, 2019

Merge remote-tracking branch 'upstream/master'
8da4435

KerbalHao suggested changes Nov 30, 2019
View reviewed changes

Comment thread4-binary/01-arraybuffer-binary-arrays/01-concat/_js.view/solution.js Outdated

javascript-translate-bot added changes requested and removed review needed labels Nov 30, 2019

KerbalHao added 正在校对 and removed changes requested labels Nov 30, 2019

arraybuffer: update trans against review comments
ecfbed6

javascript-translate-bot added the review needed label Nov 30, 2019

KerbalHao reviewed Dec 2, 2019
View reviewed changes

Comment thread4-binary/01-arraybuffer-binary-arrays/article.md

KerbalHao reviewed Dec 2, 2019
View reviewed changes

Comment thread4-binary/01-arraybuffer-binary-arrays/article.md

KerbalHao reviewed Dec 2, 2019
View reviewed changes

KerbalHao added changes requested and removed 正在校对 labels Dec 2, 2019

arraybuffer: update against review comments
163a27e

javascript-translate-bot removed the changes requested label Dec 2, 2019

KerbalHao added the ready to merge label Dec 4, 2019

leviding requested changes Dec 4, 2019
View reviewed changes

javascript-translate-bot added changes requested and removed review needed labels Dec 4, 2019

leviding removed the ready to merge label Dec 4, 2019

bemselfand others added 7 commits December 4, 2019 19:35

arraybuffer: resolve review comment
95d6677
resolve review comment Co-Authored-By: LeviDing <imdingxuewen@gmail.com>

arraybuffer: resolve review comment
73e1cba
Co-Authored-By: LeviDing <imdingxuewen@gmail.com>

arraybuffer: resolve review comment
fa9d61e
Co-Authored-By: LeviDing <imdingxuewen@gmail.com>

arraybuffer: resolve review comment
d823f7c
Co-Authored-By: LeviDing <imdingxuewen@gmail.com>

arraybuffer: resolve review comment
82ec646
Co-Authored-By: LeviDing <imdingxuewen@gmail.com>

arraybuffer: update against review comments
192760a

arraybuffer: update against review comment
e2c0214

javascript-translate-bot added review needed and removed changes requested labels Dec 4, 2019

javascript-translate-bot requested a review from a teamDecember 4, 2019 14:56

leviding approved these changes Dec 5, 2019
View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels Dec 5, 2019

javascript-translate-bot added the review needed label Dec 5, 2019

javascript-translate-bot requested a review from a teamDecember 5, 2019 12:26

leviding removed the review needed label Dec 5, 2019

leviding merged commit 34f4904 into javascript-tutorial:masterDec 5, 2019

leviding added DONE and removed needs +1 labels Dec 5, 2019

Uh oh!

Conversation

ghost commented Nov 20, 2019• edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

目标章节：4-binary/01-arraybuffer-binary-arrays

当前上游最新 commit：54984506

所做更改如下：

Uh oh!

KerbalHao commented Nov 30, 2019

Uh oh!

Uh oh!

javascript-translate-bot commented Nov 30, 2019

Uh oh!

ghost commented Nov 30, 2019

Uh oh!

Uh oh!

Uh oh!

KerbalHao left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Dec 2, 2019

Uh oh!

leviding left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Dec 4, 2019

Uh oh!

leviding commented Dec 4, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Dec 4, 2019

Uh oh!

ghost commented Dec 5, 2019

Uh oh!

javascript-translate-bot commented Dec 5, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ghost commented Nov 20, 2019•
edited by ghost
Loading

leviding commented Dec 4, 2019•
edited
Loading