CI validation: --filelist CRLF fix - #2
Closed
jaypatrickhoward wants to merge 1 commit into
Closed
Conversation
`--filelist` stopped accepting Windows CRLF line endings in 165e52c ("first implementation supporting Process Substitution", facebook#4349). That rewrite reads the list into a buffer opened in binary mode and splits it on '\n' alone. Previously the list was opened in text mode, where the Windows CRT translated CRLF to LF before the parser saw it, so stripping '\n' was enough. In binary mode the CR survives into every path: zstd: can't stat a.txt : No such file or directory -- ignored The '\r' is invisible in that message, which makes it awkward to diagnose. Drop a trailing '\r' when the line pointers are built, and add a playTests case that fails without the fix.
jaypatrickhoward
commented
Sep 7, 2026
OwnerAuthor
Upstream PR filed as facebook#4766; fork CI was 103/103 green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-only PR to run CI on the
--filelistCRLF fix before filing upstream. Do not merge.