Skip to content

Use raw signature-params instead of self-construct one.#22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gh0u1L5 wants to merge 1 commit into
base:main
Choose a base branch
from
Open

Use raw signature-params instead of self-construct one. #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions verify.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,7 @@ import (
"crypto/sha512"
"encoding/base64"
"errors"
"fmt"
"io"
"strings"
"time"
Expand DownExpand Up@@ -59,6 +60,7 @@ func (v *verifier) Verify(msg *message) error {
// on algorithm
var sigID string
var params *signatureParams
var paramsRaw string
for _, p := range paramParts {
pParts := strings.SplitN(p, "=", 2)
if len(pParts) != 2 {
Expand All@@ -73,6 +75,7 @@ func (v *verifier) Verify(msg *message) error {
if _, ok := v.keys[candidate.keyID]; ok {
sigID = pParts[0]
params = candidate
paramsRaw = pParts[1]
break
}
}
Expand DownExpand Up@@ -140,15 +143,12 @@ func (v *verifier) Verify(msg *message) error {
return err
}
}
fmt.Fprintf(&b, "\"@signature-params\": %s", paramsRaw)

if _, err := verifier.w.Write(b.Bytes()); err != nil {
return err
}

if err = canonicalizeSignatureParams(verifier.w, params); err != nil {
return err
}

err = verifier.verify(sig)
if err != nil {
return errInvalidSignature
Expand Down