Adds newline after h3 for github styling. Fixes #46 - #47
Open
viveleroi wants to merge 1 commit into
Open
Conversation
|
Can confirm. I ran into the same issue. Without a preceding line the links are broken in the Markdown output. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in the issue, github fails to render view source links correctly when preceded by an html element. The only solution I'm aware of is to force an empty line between them. Luckily, that line is not rendered:
addNode(node)Ⓢ [Ⓣ][1]
Because the
entryMarkdownarray joins with\nand\n\nis converted into<br><br>, this solution appends an empty string (which gets converted into an empty newline). It not the nicest code but it anything else would involve potentially breaking changes to the format method.Since the
h3and line of links are now separate elements, the h3 no longer needed a hard-coded\n. However, I wasn't sure which text you intended the.replace(/ {2,}/g, ' ')to apply to so I guessed.