Skip to content

fix: simplify BNC binary detection and handle Qt5 package variations - #116

Merged
jajera merged 1 commit into
mainfrom
115-fix-bnc-detection-and-qt5-deps
Aug 24, 2026
Merged

fix: simplify BNC binary detection and handle Qt5 package variations#116
jajera merged 1 commit into
mainfrom
115-fix-bnc-detection-and-qt5-deps

Conversation

@jajera

@jajera jajera commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Closes #115

Problem

  1. Binary detection failed — the extracted bnc-2.13.6 file has no exec bit set, so find -perm /111 misses it, and the subshell fallback loses the result.
  2. Qt5 package names differ across distros (Fedora has qt5-qtbase only, no qt5-qtbase-gui; Debian uses libqt5core5a; newer Ubuntu uses libqt5core5t64). The script was failing hard on unresolved package names.

Fix

  • Use direct path $TMP_DIR/bnc/bnc-${BNC_VERSION} as primary detection (we know the naming convention)
  • Use fallback chains (|| true) for Qt5 package install so missing package names don't abort the script
  • Added support for apk (Alpine) and multiple Debian/Ubuntu naming variants

@jajera
jajera merged commit 0034c06 into main Aug 24, 2026
2 checks passed
@jajera
jajera deleted the 115-fix-bnc-detection-and-qt5-deps branch August 24, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix BNC binary detection and Qt5 dependency install

1 participant