fix: allow BNC install without sudo for writable prefixes - #120
Merged
Conversation
Prefer non-sudo install/remove when the destination is writable so user installs (e.g. BNC_PREFIX=$HOME/.local) work in non-interactive shells.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #119
Summary
sudoonly when needed$HOME/.localinstall path for non-root installsTest plan
BNC_PREFIX=$HOME/.local ./install_bnc.sh installon Fedora 41 without sudobnc --helpsucceeds and Qt5 libs resolve vialdd