Skip to content

JENKINS-28271 - Gitlab Plugin does not build Merge Request when first raised - #105

Merged
bassrock merged 1 commit into
jenkinsci:masterfrom
jr4:JENKINS-28271
Oct 12, 2015
Merged

JENKINS-28271 - Gitlab Plugin does not build Merge Request when first raised#105
bassrock merged 1 commit into
jenkinsci:masterfrom
jr4:JENKINS-28271

Conversation

@jr4

@jr4jr4 commented Sep 2, 2015

Copy link
Copy Markdown

prevent NPE that was preventing the build from proceeding
tested that the build proceeds fine after that

@skyline-gleb

Copy link
Copy Markdown

@bassrock +1

@WonderCsabo

Copy link
Copy Markdown
Contributor

I can also verify this fix works well.

@johnknl

Copy link
Copy Markdown

Running into this sloppyness with older version of GitLab as well.

LGTM +1.

@WonderCsabo

Copy link
Copy Markdown
Contributor

We are using an old version (GitLab 6.9) unfortunately. BTW, is this change working with the latest GitLab versions as well?

@johnknl

Copy link
Copy Markdown

It should. Looks compatible with examples from latest GitLab docs.

bassrock added a commit that referenced this pull request Oct 12, 2015
JENKINS-28271 - Gitlab Plugin does not build Merge Request when first raised
@bassrock
bassrock merged commit 9d8dab6 into jenkinsci:masterOct 12, 2015
exceed-alae pushed a commit to exceed-alae/gitlab-plugin that referenced this pull request May 20, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jr4@skyline-gleb@WonderCsabo@johnknl@bassrock