Uh oh!
There was an error while loading. Please reload this page.
JENKINS-48987 Job build parameters are passed via request body - #315
Open
dervan wants to merge 1 commit into
Open
JENKINS-48987 Job build parameters are passed via request body#315dervan wants to merge 1 commit into
dervan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found out that for jobs with long parameters (e.g. json objects) passing via url may be a bit problematic (long urls are rejected by web server). It looks like passing via request body solves that issue and have no downsides, so please verify that and consider merging this change into master.