Skip to content

#309 - added better support for Maven Modules - #333

Open
dawon wants to merge 1 commit into
jenkinsci:masterfrom
dawon:master
Open

#309 - added better support for Maven Modules#333
dawon wants to merge 1 commit into
jenkinsci:masterfrom
dawon:master

Conversation

@dawon

Copy link
Copy Markdown

Hi so I tried adding better Maven Modules support. It is my first Pull Request, so sorry for any problems there might be. In that case, just tell me and I will try to fix it...

@khmarbaise

Copy link
Copy Markdown
Member

There are two things. First I recommend to add a copyright header in the source code files and furthermore I would request you to squash your commits and make a commit message like:

Fixed #309 - Headline Optional description

and most genius would be to add some tests if you can?
Many thanks Ah...one more thing and entry in the ReleaseNotes.md would also be a good idea...

@dawon

Copy link
Copy Markdown
Author

I already did remove the output in earlier commit. I will try to squash the commits and the rest things tomorrow.

I will also try to create some tests but I don't guarantee anything.

@dawon

Copy link
Copy Markdown
Author

So I did everything except the tests, I have to learn Mockito a bit, so I will maybe add them later when I am able to get them working...

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@dawon@khmarbaise