Uh oh!
There was an error while loading. Please reload this page.
fixes #336 by adding getClient() & getUrl() - #344
Open
mivola wants to merge 1 commit into
Open
Conversation
mivola
commented
Jul 2, 2018
ContributorAuthor
An alternative to using getView("all") in getUrl() would be to extend the JenkinsHttpConnection interface by adding "String getUrl()" method. The JenkinsHttpClient class could easily implement this as all constructors use an URI parameter. However I'm sure about other existing implementations... @khmarbaise what yo you think? |
khmarbaise
self-requested a review
September 13, 2018 19:09
mivola
commented
Apr 3, 2019
ContributorAuthor
@khmarbaise: this would be another candidate after merging PR #403 & #381 ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.