Uh oh!
There was an error while loading. Please reload this page.
[tests] Fix tests - #2833
Merged
Merged
Conversation
Use extension_loaded() directly rather than instantiating a class from the extension. The Ds\Vector class instantiation was failing under PHP 8.5 + php85Extensions.ds even though the extension reports as loaded, which made the test brittle to upstream nixpkgs changes. Also align the rm/add lines with the new package name.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Lagoja
approved these changes
May 26, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New php.ds doesn't have Vector anymore. Fix by using Seq instead.
Test plan
cli-testsworkflow passes the PHP testscript.🤖 Generated with Claude Code