Uh oh!
There was an error while loading. Please reload this page.
Revert "fix(direnv): set DEVBOX_SHELL_ENABLED when entering env via shellenv --init-hook" - #2890
Merged
Merged
Conversation
…hellenv …" This reverts commit 1219bd2.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the recently-merged change from #2861 that set DEVBOX_SHELL_ENABLED=1 when generating environment exports via devbox shellenv --init-hook (the code path used by the direnv integration).
Changes:
- Removes
DEVBOX_SHELL_ENABLEDinjection fromDevbox.EnvExportswhenRunHooksis enabled. - Removes the regression testscript that asserted
shellenv --init-hookexportsDEVBOX_SHELL_ENABLED.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| testscripts/shell/shellenv_init_hook.test.txt | Removes the test covering shellenv --init-hook output contract around DEVBOX_SHELL_ENABLED. |
| internal/devbox/devbox.go | Reverts the EnvExports behavior that exported DEVBOX_SHELL_ENABLED when init hooks are requested. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
377
to
381
| envs, err = d.ensureStateIsUpToDateAndComputeEnv(ctx, opts.EnvOptions) | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2861