Skip to content

fix: default locale to English#17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jevin98 merged 1 commit into from
May 15, 2026
Merged

fix: default locale to English #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions entrypoints/devtools-panel/lang.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -44,8 +44,8 @@ const messages = {

export const activeLocale = ref<Locale>('en')

export function initializeLocale(value: string | null, fallback = browser.i18n.getUILanguage()) {
activeLocale.value = resolveLocale(value ?? fallback)
export function initializeLocale(value: string | null) {
activeLocale.value = resolveLocale(value)
}

export function setLocale(value: Locale) {
Expand Down
19 changes: 19 additions & 0 deletions tests/unit/lang.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
import { describe, expect, it, vi } from 'vitest'
import { fakeBrowser } from 'wxt/testing'
import { activeLocale, initializeLocale } from '../../entrypoints/devtools-panel/lang'

describe('language initialization', () => {
it('defaults to English when the user has not selected a language', () => {
vi.spyOn(fakeBrowser.i18n, 'getUILanguage').mockReturnValue('zh-CN')

initializeLocale(null)

expect(activeLocale.value).toBe('en')
})

it('uses the saved language when the user has selected one', () => {
initializeLocale('zh_CN')

expect(activeLocale.value).toBe('zh_CN')
})
})
Loading