Skip to content

Support limit and offset in AqlQueryBuilder - #371

Merged
yahavi merged 4 commits into
jfrog:devfrom
sailingcat:pagination
Nov 7, 2023
Merged

Support limit and offset in AqlQueryBuilder#371
yahavi merged 4 commits into
jfrog:devfrom
sailingcat:pagination

Conversation

@sailingcat

@sailingcatsailingcat commented Mar 29, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor
  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.

@sailingcat

sailingcat commented May 12, 2023

Copy link
Copy Markdown
ContributorAuthor

Includes limit (Done in #294).

@sailingcat
sailingcat marked this pull request as draft July 3, 2023 07:20
@sailingcat
sailingcat marked this pull request as ready for review July 3, 2023 07:20
@sailingcat

sailingcat commented Jul 3, 2023

Copy link
Copy Markdown
ContributorAuthor

@eyalbe4 Could you please review my PR please ?

@yahaviyahavi added the safe to test Approve running integration tests on a pull request label Oct 1, 2023
@github-actionsgithub-actionsBot removed the safe to test Approve running integration tests on a pull request label Oct 1, 2023
@yahaviyahavi added the safe to test Approve running integration tests on a pull request label Nov 7, 2023
@github-actionsgithub-actionsBot removed the safe to test Approve running integration tests on a pull request label Nov 7, 2023
@yahaviyahavi changed the title feat(aql): Adding Pagination to AQL Query BuilderSupport sort and limit in AqlQueryBuilderNov 7, 2023
@yahaviyahavi added the improvement Automatically generated release notes label Nov 7, 2023
@yahaviyahavi changed the title Support sort and limit in AqlQueryBuilderSupport limit and offset in AqlQueryBuilderNov 7, 2023
@yahaviyahavi added the safe to test Approve running integration tests on a pull request label Nov 7, 2023
@github-actionsgithub-actionsBot removed the safe to test Approve running integration tests on a pull request label Nov 7, 2023
yahavi
yahavi approved these changes Nov 7, 2023
View reviewed changes

@yahaviyahavi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sailingcat!

@yahavi
yahavi merged commit de29d0b into jfrog:devNov 7, 2023
@sailingcat
sailingcat deleted the pagination branch November 8, 2023 13:35
@yahavi

yahavi commented Nov 9, 2023

Copy link
Copy Markdown
Member

Hey @sailingcat,
The latest release of Artifactory Java client, version 2.17.0, is now available. This update incorporates the changes mentioned in #371 & #370, which you contributed. Please consider upgrading, and your feedback would be greatly valued.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yahaviyahaviyahavi approved these changes

Assignees

No one assigned

Labels

improvementAutomatically generated release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sailingcat@yahavi