') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); MSVC C4996 is suppressed in a public header, hiding deprecation warnings from the library and its consumers · Issue #42 · jkalias/sqlite-reflection · GitHub
Skip to content

MSVC C4996 is suppressed in a public header, hiding deprecation warnings from the library and its consumers #42

Open
Open
MSVC C4996 is suppressed in a public header, hiding deprecation warnings from the library and its consumers#42
Labels
robustness

Description

@jkalias
jkalias
opened on Jul 26, 2026

Problem

include/reflection_export.h disables a set of MSVC warnings at the top of the file, including C4996 (use of a deprecated declaration):

#pragma warning(disable : 4018) // signed/unsigned warnings
#pragma warning(disable : 4100)
#pragma warning(disable : 4251)
#pragma warning(disable : 4512)
#pragma warning(disable : 4996)

C4996 is the warning that would have flagged std::wstring_convert and <codecvt>, the subject of #25. Because it was suppressed, a facet deprecated since C++17 sat in the conversion path without a single build warning on any of the four MSVC CI legs. #25 was found by reasoning about wchar_t widths, not by the toolchain telling anyone.

<codecvt> is gone now, so nothing in the library currently depends on the suppression for that reason — but nothing would flag a reintroduction either, whether of <codecvt> or of any other deprecated API.

Two separate concerns

1. The suppression hides real deprecation warnings. This is the one that bit us in #25.

2. It is a public header.reflection_export.h is under include/ and is pulled in by the public API headers, so every one of these #pragma warning(disable: ...) lines leaks into the translation unit of anyone consuming the library. A consumer who includes database.h silently loses C4996 — and C4018, C4100, C4251, C4512 — in their own code. A library should not turn off its users' warnings as a side effect of being included.

Suggested direction

  • Establish whether the library still needs C4996 suppressed at all. If some vendored source needs it (src/sqlite3.c is the likely candidate), scope it to that file with push/pop rather than a public header.
  • Same question for the other four codes, which have no explanatory comment beyond C4018's.
  • If any must stay, move them behind BUILD_SQLITE_REFLECTION so they apply while building the library but not to consumers, and pair each with a comment saying what needs it.
  • Worth confirming afterwards that a deliberate use of a deprecated API does produce a warning on the MSVC CI legs, so the guard is verified rather than assumed.

Notes

Pre-existing, and out of scope for #40 — CONTRIBUTING.md asks that lint fixes stay scoped to the code a change touches. Raised during review of that PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    robustness

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions