Ensure err blocks keep blank line before following HTML - #12
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # phase 2: insert whatever notebook output is available into staged pages | ||
| if notebook_future and notebook_future.done(): | ||
| outputs, code_map = notebook_future.result() | ||
| notebook_executor.shutdown(wait=False) | ||
| notebook_executor = None |
There was a problem hiding this comment.
The phase‑2 loop now calls substitute_code_placeholders even when notebook_future is still running (1216‑1220), passing empty outputs. That helper removes the data-script placeholders and swaps in a “Running notebook …” banner (see 1091‑1104), so when phase 4 later waits for the future there are no placeholders left to update and the executed outputs never make it into the staged or display HTML. Any notebook that takes longer than the pandoc render will now remain stuck showing the waiting message instead of the finished cell output.
Useful? React with 👍 / 👎.
Summary
lines
Testing
Codex Task