Clarify and regression-test explicit stdin body handling - #61
Open
FelixLisczyk wants to merge 3 commits into
Open
Clarify and regression-test explicit stdin body handling#61FelixLisczyk wants to merge 3 commits into
FelixLisczyk wants to merge 3 commits into
Conversation
Make stdin consumption testable and opt-in through the explicit '-' flag value across descriptions, comments, and replies. Align command help and documentation with the safe non-blocking contract and add propagation, edge-case, and help-text regression coverage.\n\nCo-Authored-By: Claude <noreply@anthropic.com>
Add empty-input, attachment propagation, and no-request tests for CLI body handling. Make the injected stdin seam deterministic when unconfigured and document the actual helper entry points. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Before this change, command documentation implied that piping input was sufficient:
However, the CLI only consumed stdin when the corresponding flag explicitly had the value
-. The piped content could therefore be silently ignored, producing an empty description or leaving an existing description unchanged. The same documentation inconsistency affected project descriptions and issue comment/reply bodies.Automatic stdin detection is intentionally not restored because it can cause commands to block in automation environments.
Changes
This PR makes the existing explicit-stdin contract consistent and clearly documented:
It also:
Testing
make testpasses.