Document using limiting APIs for Python thread pools - #234
Conversation
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
|
I think once this merged maybe this could be released? |
There was a problem hiding this comment.
A first pass of feedback. I think it would be helpful if someone else who did not review all your past PRs could have a fresh look at this. Maybe @cakedev0, @lesteve and/or @jeremiedbb?
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
|
BTW, the CI should now be green if you sync this PR's branch with the master branch. |
cakedev0
left a comment
There was a problem hiding this comment.
Some small findings here and there. Plus two genuine, possibly naive, questions. Otherwise, I found it relatively clear and easy to understand.
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Arthur Lacote <arthur.lcte@gmail.com>
…o 215-limits-for-thread-pools
|
I believe I've addressed all the review comments, thanks for the detailed feedback. |
cakedev0
left a comment
There was a problem hiding this comment.
LGTM, based on the diff since my last review.
Thank you for the nice documentation effort! 😄
| To prevent loading shared libraries repeatedly, you can reuse a | ||
| Whenever `threadpool_limits` is called, it needs to do some work (inspecting and getting access to third-party shared libraries) that can take some time. | ||
| To prevent the performance cost of doing this work every time, you can reuse a |
|
Thanks again! I will follow-up with a release soon. |
|
If you also plan a release of loky, can we please merge joblib/loky#651 before? 🙏 |
|
I think it's only a release for threadpoolctl for now, but I haven't forgotten your loky PR 😉. |
|
Note I filed another issue that is a release blocker for threaded support, hoping to open a PR today.
|
Fixes #215