ADR-389: Rename design-work-items to source-work-item-sync and generalize it

[jodavis-claude]

Generalizes the skill to be callable after either write-proposal or write-detailed-design, summarizing whichever Proposal/Detailed Design doc(s) are finalized so far into the originating tracked source's description. Replace/Update dispatch semantics via work-tracking config are unchanged.

---

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

[github-actions]

build-and-test: Python test results

Status: ✅ Passed

Test log

[jodavis-claude]

Review summary — ADR-389

Reviewed the rename/generalization of design-work-items → source-work-item-sync.

Requirements

• Exit criterion 1 (rename): confirmed — plugins/dev-team/skills/design-work-items/ is gone, plugins/dev-team/skills/source-work-item-sync/SKILL.md exists with frontmatter name: source-work-item-sync and updated extension-point path.
• Exit criterion 2 (callable after either write-proposal or write-detailed-design, no document-type assumption baked in): confirmed — frontmatter and body wording were generalized throughout ("the brief that produced these document(s)", "whichever document(s) are finalized so far"); the deliverables-links bullet correctly notes it only applies once a Detailed Design's ## Deliverables section exists, preserving existing behavior for the second call site. Variadic <finalized-doc-path>... argument shape reasonably satisfies "no document-type assumption baked in" (an open choice per the task brief).
• Exit criterion 3 (validate against real ADR-380 source item): could not be run against real data — no ADR-380 Proposal/Detailed Design document exists yet in this repo (same precursor gap already flagged in ADR-386/ADR-388's context). The developer's scratchpad dry-run substitution and clear documentation of this gap in the Implementation Summary is a reasonable call given the external blocker, consistent with the ADR-388 precedent for the identical situation. Not held against this PR, but flagging for visibility — worth re-running once a real ADR-380 doc exists.

Scope boundary — confirmed via grep that the three explicitly-reserved files (commands/write-design-spec.md, commands/add-to-spec.md, plugins/dev-team/README.md) were left untouched, as required; only the one skill file was renamed/edited.

Correctness/consistency — wording closely follows the dev-spec-task-work-items sibling pattern as suggested in the brief. Replace/Update dispatch semantics, the work-tracking: null guard, and the "ask the user rather than guess" fallback all carried over unchanged, as required.

Documentation — no _doc_*.md file exists for this subsystem in this repo, so no architecture doc update was needed.

Tests — none added; consistent with this being a Wrapper-tier prompt/config component with no executable/conditional logic, per CONTRIBUTING.md's testing guidance being scoped to code with logic.

No Priority 1–4 issues found. Approving.

[jodavis-claude]

Sign-off review — ADR-389

No unresolved review threads exist on this PR (the prior review had no inline comments, only an
overall summary that already approved the change). No commits have landed since that review — the
PR still consists of the single commit 8b8962d (rename/generalization of design-work-items →
source-work-item-sync).

Re-scanned the modified files for regressions:

• plugins/dev-team/skills/source-work-item-sync/SKILL.md — confirmed present with the
  generalized frontmatter (name: source-work-item-sync, variadic
  <finalized-doc-path>... argument-hint, document-type-neutral description/body wording), the
  work-tracking: null guard, the Replace/Update dispatch semantics unchanged, and the
  deliverables-links bullet correctly scoped to "once a Detailed Design's ## Deliverables
  section exists."
• plugins/dev-team/skills/design-work-items/ confirmed removed (git mv, not a copy).
• Confirmed via gh pr diff --name-only that only these two paths are touched by this PR — the
  three explicitly out-of-scope files (commands/write-design-spec.md, commands/add-to-spec.md,
  plugins/dev-team/README.md) remain untouched, as required by the task brief.

No Priority 1-4 issues found. Sign-off: approved.