Skip to content

a tiny workaround for httplib2 redirect bug - #214

Open
ivishnevs wants to merge 1 commit into
joestump:masterfrom
ivishnevs:httplib2-redirect-bug
Open

a tiny workaround for httplib2 redirect bug#214
ivishnevs wants to merge 1 commit into
joestump:masterfrom
ivishnevs:httplib2-redirect-bug

Conversation

@ivishnevs

@ivishnevsivishnevs commented Feb 7, 2017

Copy link
Copy Markdown

if 'location' header is in response object, http2lib try to redirect and use self.request method with body=None argument; this behavior implies a problem like this - #203 and etc.

if response.status in [302, 303]:
redirect_method = "GET"
body = None <--------- (response, content) = self.request(
location, method=redirect_method, body=body,
headers=headers, redirections=redirections - 1)

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #214 into master will not impact coverage by -0.2%.

@@ Coverage Diff @@## master #214 +/- ##
=========================================
- Coverage 96.05% 95.86% -0.2% 
=========================================
Files 5 5 Lines 482 484 +2 =========================================
+ Hits 463 464 +1 - Misses 19 20 +1
Impacted FilesCoverage Δ
oauth2/init.py99.77% <50%> (-0.23%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6689960...b8bf881. Read the comment docs.

@ivishnevsivishnevs mentioned this pull request Feb 8, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ivishnevs@codecov-io